jvenant commented on code in PR #10731:
URL: https://github.com/apache/pinot/pull/10731#discussion_r1189460970
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskGeneratorTest.java:
##########
@@ -78,4 +86,52 @@ public void testRealCluster()
ControllerTest.sendPostRequest(_controllerRequestURLBuilder.forClusterConfigs(),
request);
Assert.assertEquals(_generator.getNumConcurrentTasksPerInstance(), 1);
}
+
+ @Test
+ public void testGenerateTaskSpec() throws Exception {
+ URL resourcesLoc =
SegmentGenerationAndPushTaskGeneratorTest.class.getClassLoader().getResource(".");
+ SegmentGenerationAndPushTaskExecutor executor = new
SegmentGenerationAndPushTaskExecutor();
+ Schema schema = new Schema.SchemaBuilder().build();
+ // FieldUtils.writeField(executor, "_pinotTaskConfig", new
PinotTaskConfig("",
Review Comment:
Fixed in bb90840fffa9e1f3d2f03af2f8270127bfe91787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
