walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190219754
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PinotLogicalQueryPlanner.java: ########## @@ -0,0 +1,161 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.logical; + +import com.google.common.collect.ImmutableList; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import org.apache.calcite.rel.RelDistribution; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.RelRoot; +import org.apache.pinot.query.planner.PlanFragment; +import org.apache.pinot.query.planner.PlanFragmentMetadata; +import org.apache.pinot.query.planner.QueryPlan; +import org.apache.pinot.query.planner.QueryPlanMetadata; +import org.apache.pinot.query.planner.SubPlan; +import org.apache.pinot.query.planner.SubPlanMetadata; +import org.apache.pinot.query.planner.plannode.MailboxReceiveNode; +import org.apache.pinot.query.planner.plannode.MailboxSendNode; +import org.apache.pinot.query.planner.plannode.PlanNode; +import org.apache.pinot.query.planner.plannode.TableScanNode; + + +/** + * PinotLogicalQueryPlanner walks top-down from {@link RelRoot} and construct a forest of trees with {@link PlanNode}. + * + * This class is non-threadsafe. Do not reuse the stage planner for multiple query plans. + */ +public class PinotLogicalQueryPlanner { + + /** + * Construct the dispatchable plan from relational logical plan. + * + * @param relRoot relational plan root. + * @return dispatchable plan. + */ Review Comment: this statement is confusing suggest: ```suggestion /** * planQuery achieves 2 objective: * 1. convert Calcite's {@link RelNode} to Pinot's {@link PlanNode} format from the {@link RelRoot} of Calcite's LogicalPlanner result. * 2. while walking Calcite's {@link RelNode} tree, populate {@link QueryPlanMetadata}. * * @param relRoot relational plan root. * @return dispatchable plan. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
