[GitHub] [pinot] ruhz3 opened a new issue, #10070: [Question] Is it possible to insert thrift data into pinot through stream ingestion?

ruhz3 opened a new issue, #10070: URL: https://github.com/apache/pinot/issues/10070 Hi, I' am Hyungju. I'm trying to apply this great product on my service. Reading the documents, It seemed like thrift ingestion is only possible in batch ingestion. I tried with below con

[GitHub] [pinot] sajjad-moradi commented on issue #10060: RT segment size does NOT follow "realtime.segment.flush.desired.size" parameter

sajjad-moradi commented on issue #10060: URL: https://github.com/apache/pinot/issues/10060#issuecomment-1373205082 This is a false alarm. The segment size reported here are for "tar.gz" version of the segments, not the original ones. I just double checked one of our tables and un-tarred a s

[GitHub] [pinot] sajjad-moradi closed issue #10060: RT segment size does NOT follow "realtime.segment.flush.desired.size" parameter

sajjad-moradi closed issue #10060: RT segment size does NOT follow "realtime.segment.flush.desired.size" parameter URL: https://github.com/apache/pinot/issues/10060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063091637 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java: ## @@ -77,6 +77,9 @@ public int getNumConsumingSegments

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063091381 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1594,4 +1616,9 @@ public String getSegmentName() { p

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063091118 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1554,6 +1557,25 @@ private void createPartitionMetadata

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063090872 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -69,4 +69,13 @@ protected static PinotDataBufferMemoryMana

[GitHub] [pinot] sajjad-moradi commented on issue #10069: Add a controller API to reflect whether force commit is finished

sajjad-moradi commented on issue #10069: URL: https://github.com/apache/pinot/issues/10069#issuecomment-1373082267 Another option is to use pauseStatus endpoint on the client side: 1. Client calls /pauseStatus to get the list of existing consuming segments. 2. Client issues the force co

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063043991 ## pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/ConsumptionDelayTrackerTest.java: ## @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software F

[GitHub] [pinot] codecov-commenter commented on pull request #10068: [Cleanup] Remove ConvertToRawIndexTask

codecov-commenter commented on PR #10068: URL: https://github.com/apache/pinot/pull/10068#issuecomment-1373029360 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10068?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] walterddr commented on issue #9655: Support multi-thread execution on multistage engine

walterddr commented on issue #9655: URL: https://github.com/apache/pinot/issues/9655#issuecomment-1373021032 CC @agavra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] walterddr commented on issue #9970: [multistage] default group limit unable to override

walterddr commented on issue #9970: URL: https://github.com/apache/pinot/issues/9970#issuecomment-1373020243 I think it is related to #9957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pinot] Jackie-Jiang opened a new issue, #10069: Add a controller API to reflect whether force commit is finished

Jackie-Jiang opened a new issue, #10069: URL: https://github.com/apache/pinot/issues/10069 Force commit is executed asynchronously leveraging the Helix messages. Currently there is no way to tell whether force commit is finished or not. We want to add a controller API to indicate whether al

[GitHub] [pinot] codecov-commenter commented on pull request #10067: Bump json5 from 1.0.1 to 1.0.2 in /pinot-controller/src/main/resources

codecov-commenter commented on PR #10067: URL: https://github.com/apache/pinot/pull/10067#issuecomment-1373008148 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10068: [Cleanup] Remove ConvertToRawIndexTask

Jackie-Jiang opened a new pull request, #10068: URL: https://github.com/apache/pinot/pull/10068 Remove the ConvertToRawIndex minion task for the following reasons: 1. Pinot supports on-the-fly index conversion now, so this minion task is no longer needed 2. The task requires v1 segment

[pinot] branch master updated (fd0267df81 -> 97678f8745)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from fd0267df81 [feature] Add pinot-clp-log plugin to encode user-specified fields with CLP during ingestion (#9942) a

[GitHub] [pinot] Jackie-Jiang merged pull request #10066: add query option allowing to scan startree index tree nodes

Jackie-Jiang merged PR #10066: URL: https://github.com/apache/pinot/pull/10066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/json5-1.0.2 created (now f5f135af56)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/json5-1.0.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at f5f135af56 Bump json5 from 1.0.1 to 1.0.2 in /pi

[GitHub] [pinot] dependabot[bot] opened a new pull request, #10067: Bump json5 from 1.0.1 to 1.0.2 in /pinot-controller/src/main/resources

dependabot[bot] opened a new pull request, #10067: URL: https://github.com/apache/pinot/pull/10067 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases";>json5's releases. v1.0.2 Fix: Prop

[GitHub] [pinot] jadami10 commented on issue #10064: Deleting a table does not reset metric gauges

jadami10 commented on issue #10064: URL: https://github.com/apache/pinot/issues/10064#issuecomment-1372965127 wow... what timing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] jadami10 commented on issue #10064: Deleting a table does not reset metric gauges

jadami10 commented on issue #10064: URL: https://github.com/apache/pinot/issues/10064#issuecomment-1372965047 wow... what timing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[pinot] branch master updated (036f7ddaa0 -> fd0267df81)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 036f7ddaa0 output explain plan when compatibility verifier rejects change in query execution (#10063) add fd026

[GitHub] [pinot] chenboat merged pull request #9942: [feature] Add pinot-clp-log plugin to encode user-specified fields with CLP during ingestion

chenboat merged PR #9942: URL: https://github.com/apache/pinot/pull/9942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[pinot] branch master updated (02dc4b4f09 -> 036f7ddaa0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 02dc4b4f09 Remove table gauge metrics once table got deleted. (#10062) add 036f7ddaa0 output explain plan when com

[GitHub] [pinot] Jackie-Jiang merged pull request #10063: output explain plan when compatibility verifier rejects change in query execution

Jackie-Jiang merged PR #10063: URL: https://github.com/apache/pinot/pull/10063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable

ankitsultana commented on code in PR #10005: URL: https://github.com/apache/pinot/pull/10005#discussion_r1062990982 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/worker/WorkerAssignmentStrategy.java: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apac

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10043: evaluate EQ queries against range index when available

Jackie-Jiang commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1062985665 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[GitHub] [pinot] Jackie-Jiang commented on issue #10064: Deleting a table does not reset metric gauges

Jackie-Jiang commented on issue #10064: URL: https://github.com/apache/pinot/issues/10064#issuecomment-1372918463 Fixed with #10062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] Jackie-Jiang closed issue #10064: Deleting a table does not reset metric gauges

Jackie-Jiang closed issue #10064: Deleting a table does not reset metric gauges URL: https://github.com/apache/pinot/issues/10064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] Jackie-Jiang commented on pull request #10044: push utf8 comparison down into ValueReader

Jackie-Jiang commented on PR #10044: URL: https://github.com/apache/pinot/pull/10044#issuecomment-1372916301 > I think @klsince's question needs addressing - what happens when there are two invalid UTF8 sequences at the mismatch, can we return 0 spuriously, I'll address that before merging.

[GitHub] [pinot] klsince opened a new pull request, #10066: add query option allowing to scan startree index tree nodes

klsince opened a new pull request, #10066: URL: https://github.com/apache/pinot/pull/10066 Add this option to test scaning vs. binary search while traversing the StarTree index easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062938976 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062938976 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[pinot] branch master updated (2b7f4ac295 -> 02dc4b4f09)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2b7f4ac295 [refactor] move min/max combine out (#10058) add 02dc4b4f09 Remove table gauge metrics once table got

[GitHub] [pinot] xiangfu0 merged pull request #10062: Remove table gauge metrics once table got deleted

xiangfu0 merged PR #10062: URL: https://github.com/apache/pinot/pull/10062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062938976 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062938976 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[pinot] branch master updated (c4ae332df9 -> 2b7f4ac295)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c4ae332df9 Add pinot prefix to config namespace (#10059) add 2b7f4ac295 [refactor] move min/max combine out (#10058

[GitHub] [pinot] walterddr merged pull request #10058: [refactor] move min/max combine out

walterddr merged PR #10058: URL: https://github.com/apache/pinot/pull/10058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1062886088 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ## @@ -45,8 +45,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge { // De

[GitHub] [pinot] Jackie-Jiang commented on issue #10061: The function lastwithtime throws an exception when the applied column has Japanese characters

Jackie-Jiang commented on issue #10061: URL: https://github.com/apache/pinot/issues/10061#issuecomment-1372676803 This is fixed in #9985, and will be released in `0.12.0` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pinot] Jackie-Jiang closed issue #10061: The function lastwithtime throws an exception when the applied column has Japanese characters

Jackie-Jiang closed issue #10061: The function lastwithtime throws an exception when the applied column has Japanese characters URL: https://github.com/apache/pinot/issues/10061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1062844784 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -69,4 +69,13 @@ protected static PinotDataBufferMemoryMana

[GitHub] [pinot] richardstartin closed pull request #10065: Debug compatibility verifier

richardstartin closed pull request #10065: Debug compatibility verifier URL: https://github.com/apache/pinot/pull/10065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1062843087 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ## @@ -45,8 +45,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge { // De

[GitHub] [pinot] codecov-commenter commented on pull request #10065: Debug compatibility verifier

codecov-commenter commented on PR #10065: URL: https://github.com/apache/pinot/pull/10065#issuecomment-1372657660 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] codecov-commenter commented on pull request #10063: output explain plan when compatibility verifier rejects change in query execution

codecov-commenter commented on PR #10063: URL: https://github.com/apache/pinot/pull/10063#issuecomment-1372651988 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[pinot] branch range-index-equals-queries updated (a3288916a1 -> 96ea1bfa13)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard a3288916a1 output explain plan when compatibility verifier rejects change in query executi

[pinot] 02/02: print explain plan for successful verifications to compare against

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit f13af6b986b6ea8e298e2bac14a6acfafca11b9c Author: Richard Startin AuthorDate: Thu Jan 5 18:5

[pinot] branch debug-compatibility-verifier updated (627412e48c -> f13af6b986)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git discard 627412e48c print explain plan for successful verifications to compare against discard b

[pinot] 01/02: output explain plan when compatibility verifier rejects change in query execution

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit 2ac8cd0827e4a0bb0359112c5a533c3a3d0a7a04 Author: Richard Startin AuthorDate: Thu Jan 5 18:3

[pinot] branch range-index-equals-queries updated (6f4b4c38e4 -> a3288916a1)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard 6f4b4c38e4 output explain plan when compatibility verifier rejects change in query executi

[pinot] branch range-index-equals-queries updated (460d21238a -> 6f4b4c38e4)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git omit 460d21238a output explain plan when compatibility verifier rejects change in query executi

[pinot] branch compatibility-verifier-explain-plan updated (64a6bf8e73 -> 2a40f96e15)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch compatibility-verifier-explain-plan in repository https://gitbox.apache.org/repos/asf/pinot.git discard 64a6bf8e73 output explain plan when compatibility verifier rejects change in quer

[pinot] 01/02: output explain plan when compatibility verifier rejects change in query execution

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit bf3e2487ee6615ab704851cdf1d546b83e539e75 Author: Richard Startin AuthorDate: Thu Jan 5 18:3

[pinot] branch debug-compatibility-verifier updated (aa82bd950b -> 627412e48c)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git discard aa82bd950b checkstyle discard 315381ec48 print explain plan for successful verifications

[pinot] 02/02: print explain plan for successful verifications to compare against

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit 627412e48c5e0f3eac380013ea4515caad51ca41 Author: Richard Startin AuthorDate: Thu Jan 5 18:5

[pinot] branch compatibility-verifier-explain-plan updated (dec2288a61 -> 64a6bf8e73)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch compatibility-verifier-explain-plan in repository https://gitbox.apache.org/repos/asf/pinot.git omit dec2288a61 output explain plan when compatibility verifier rejects change in quer

[pinot] branch range-index-equals-queries updated (bafab5c87f -> 460d21238a)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git omit bafab5c87f output explain plan when compatibility verifier rejects change in query executi

[GitHub] [pinot] jadami10 opened a new issue, #10064: Deleting a table does not reset metric gauges

jadami10 opened a new issue, #10064: URL: https://github.com/apache/pinot/issues/10064 When a table with error segments is deleted, the "segments_in_error_state" gauge remains at the same value. This should either go to 0 or stop reporting all together. -- This is an automated message fr

[pinot] branch compatibility-verifier-explain-plan updated (e608b9e59c -> dec2288a61)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch compatibility-verifier-explain-plan in repository https://gitbox.apache.org/repos/asf/pinot.git omit e608b9e59c output explain plan when compatibility verifier rejects change in quer

[pinot] branch debug-compatibility-verifier updated: checkstyle

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/debug-compatibility-verifier by this push:

[pinot] 02/02: print explain plan for successful verifications to compare against

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit 315381ec483682ad8ab2e63bd3328045e9692d59 Author: Richard Startin AuthorDate: Thu Jan 5 18:4

[pinot] branch debug-compatibility-verifier created (now 315381ec48)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git at 315381ec48 print explain plan for successful verifications to compare against This bran

[pinot] 01/02: output explain plan when compatibility verifier rejects change in query execution

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch debug-compatibility-verifier in repository https://gitbox.apache.org/repos/asf/pinot.git commit 5c7d59cf9c7ea3ffe45a154ff9653c43674098a5 Author: Richard Startin AuthorDate: Thu Jan 5 18:3

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10058: [refactor] move min/max combine out

Jackie-Jiang commented on code in PR #10058: URL: https://github.com/apache/pinot/pull/10058#discussion_r1062782071 ## pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java: ## @@ -45,13 +48,16 @@ import org.apache.pinot.spi.trace.InvocationRecording; import

[GitHub] [pinot] richardstartin opened a new pull request, #10063: output explain plan when compatibility verifier rejects change in query execution

richardstartin opened a new pull request, #10063: URL: https://github.com/apache/pinot/pull/10063 Makes the compatibility verifier a bit easier to understand when it fails by printing the explain plan. -- This is an automated message from the Apache Git Service. To respond to the message,

[pinot] 01/01: output explain plan when compatibility verifier rejects change in query execution

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch compatibility-verifier-explain-plan in repository https://gitbox.apache.org/repos/asf/pinot.git commit e608b9e59c6af6a25072725a1e9043d1e5430207 Author: Richard Startin AuthorDate: Thu Jan

[pinot] branch compatibility-verifier-explain-plan created (now e608b9e59c)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch compatibility-verifier-explain-plan in repository https://gitbox.apache.org/repos/asf/pinot.git at e608b9e59c output explain plan when compatibility verifier rejects change in quer

[pinot] branch range-index-equals-queries updated (ac2839fad1 -> bafab5c87f)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git from ac2839fad1 evaluate EQ queries against range index when available add bafab5c87f outpu

[GitHub] [pinot] walterddr commented on a diff in pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable

walterddr commented on code in PR #10005: URL: https://github.com/apache/pinot/pull/10005#discussion_r1062726390 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/worker/WorkerAssignmentStrategy.java: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] walterddr commented on a diff in pull request #10005: [multistage] Add Worker SPI to Make Worker Assignment Configurable

walterddr commented on code in PR #10005: URL: https://github.com/apache/pinot/pull/10005#discussion_r1062726390 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/worker/WorkerAssignmentStrategy.java: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache

[pinot] branch master updated: Add pinot prefix to config namespace (#10059)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c4ae332df9 Add pinot prefix to config namespace (#

[GitHub] [pinot] walterddr merged pull request #10059: Add pinot Prefix to Server Thread Pool Config

walterddr merged PR #10059: URL: https://github.com/apache/pinot/pull/10059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] walterddr commented on pull request #9956: [multistage] [observability] Add debugging log for mailbox service

walterddr commented on PR #9956: URL: https://github.com/apache/pinot/pull/9956#issuecomment-1372521174 @61yao could we address the comments and rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pinot] walterddr commented on pull request #9957: [multistage] [feature] Add a query option to pass some v1 limit

walterddr commented on PR #9957: URL: https://github.com/apache/pinot/pull/9957#issuecomment-1372520753 @61yao could we address the comments and rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062702053 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062702053 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062700111 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062685840 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062684603 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062679718 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] egalpin commented on pull request #10000: [Issue 7519] Adds support for multiple filtered/unfiltered aggregations with GROUP BY

egalpin commented on PR #1: URL: https://github.com/apache/pinot/pull/1#issuecomment-1372454571 Will do @kishoreg 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[pinot] branch range-index-equals-queries updated (f72f22eac2 -> ac2839fad1)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard f72f22eac2 evaluate EQ queries against range index when available add 303b1a7cbe [Issu

[pinot] branch propagate-inversion updated (4307f59bf5 -> 464ea2c3d0)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch propagate-inversion in repository https://gitbox.apache.org/repos/asf/pinot.git omit 4307f59bf5 print explain plan when integration test query fails to ease debugging omit b403f2

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1062528508 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReaderComparisons.java: ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] richardstartin commented on pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on PR #10044: URL: https://github.com/apache/pinot/pull/10044#issuecomment-1372275649 FWIW I think this code is correct, and I know it addresses a bottleneck which can account for up to 20-25% of CPU samples when I've profiled servers Pinot in the past, but I can't

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1062520494 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReaderComparisons.java: ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Sof

[pinot] branch pushdown-comparison updated (7f9f1b5733 -> eae55a9f04)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch pushdown-comparison in repository https://gitbox.apache.org/repos/asf/pinot.git omit 7f9f1b5733 don't apply to BYTES dictionaries, refactor omit dda4a8c8fa push unsigned byte comp

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1062499804 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] xiangfu0 opened a new pull request, #10062: Remove table gauge metrics once table got deleted

xiangfu0 opened a new pull request, #10062: URL: https://github.com/apache/pinot/pull/10062 Remove table gauge metrics once existing table got deleted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] richardstartin commented on pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on PR #10044: URL: https://github.com/apache/pinot/pull/10044#issuecomment-1371990042 > LGTM. Thanks for adding the tests! I think @klsince's question needs addressing - what happens when there are two invalid UTF8 sequences at the mismatch, can we return 0 sp

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1062280930 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReaderComparisons.java: ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] huaheh opened a new issue, #10061: The function lastwithtime throws an exception when the applied column has Japanese characters

huaheh opened a new issue, #10061: URL: https://github.com/apache/pinot/issues/10061 The exception is execute query error: QueryExecutionError: java.lang.RuntimeException: Caught exception while building data table. at org.apache.pinot.core.operator.blocks.InstanceResponseBlock.(Ins

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1062279993 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReaderComparisons.java: ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Sof

[pinot] branch master updated: print explain plan when integration test query fails to ease debugging (#10057)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a46b05f8f6 print explain plan when integr

[GitHub] [pinot] richardstartin merged pull request #10057: print explain plan when integration test query fails to ease debugging

richardstartin merged PR #10057: URL: https://github.com/apache/pinot/pull/10057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pin

[GitHub] [pinot] richardstartin commented on pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on PR #10043: URL: https://github.com/apache/pinot/pull/10043#issuecomment-1371979974 The compatibility verifier is failing because the numDocsScannedInFilter increases, but timeUsedMs decreases by a large factor in each case: e.g. `numEntriesScannedInFilter` increa

[GitHub] [pinot] navina commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

navina commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1062197948 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1594,4 +1616,9 @@ public String getSegmentName() { pub