richardstartin commented on PR #10044: URL: https://github.com/apache/pinot/pull/10044#issuecomment-1372275649
FWIW I think this code is correct, and I know it addresses a bottleneck which can account for up to 20-25% of CPU samples when I've profiled servers Pinot in the past, but I can't be the one to merge this PR because I'm not taking on the risk of it being incorrect, it was just a fun problem to solve. So please vet this PR some more and merge it at your own risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org