jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1063090872


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -69,4 +69,13 @@ protected static PinotDataBufferMemoryManager 
getMemoryManager(String consumerDi
 
   public abstract Map<String, PartitionLagState> getPartitionToLagState(
       Map<String, ConsumerPartitionState> consumerPartitionStateMap);
+
+  /**
+   * The RT segment data manager can handle status change from external 
components like the ConsumptionStatusChecker
+   * etc. Currently, it acts as a way to signal the RT Segment data manager 
that the current partition has caught up.
+   *
+   * @param caughtUpWithUpstream Boolean indicating if the partition has 
caught up with upstream source or not based on
+   *                            the strategy used in the {@literal 
IngestionBasedConsumptionStatusChecker}
+   */
+  public abstract void notifyConsumptionCaughtUp(boolean caughtUpWithUpstream);

Review Comment:
   Code now changed to use server ready signal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to