ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034364823
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to t
navina commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1034352337
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -33,18 +34,25 @@
public class PartialUpsertHandler {
// _co
navina commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1034350597
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -33,18 +34,25 @@
public class PartialUpsertHandler {
// _co
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 26a83ba4f3 [bugfix] fix mergeRollupTask metrics (#
snleee merged PR #9864:
URL: https://github.com/apache/pinot/pull/9864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.
amrishlal commented on issue #9820:
URL: https://github.com/apache/pinot/issues/9820#issuecomment-1330067945
Discussed briefly with @Jackie-Jiang offline. Jackie mentioned that these
proposed changes in `NumericalFilterOptimizer` won't apply to cases where the
LHS of the predicate is not DO
yupeng9 commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034228290
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Ap
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034225864
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to t
siddharthteotia commented on issue #9055:
URL: https://github.com/apache/pinot/issues/9055#issuecomment-1329962107
Implementation for runtime query killing on server has been merged as part
of https://github.com/apache/pinot/pull/9727
@jasperjiaguo is working to extend the support on
agavra commented on PR #9832:
URL: https://github.com/apache/pinot/pull/9832#issuecomment-1329951586
@Jackie-Jiang - I removed the usage of this flag and v1 changes, this PR now
only affects the multistage engine :) hopefully there's no concerns now
--
This is an automated message from th
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 443b8c542c Clean up transform functions (#9858)
add d458668690 Do not sort the instances in InstancePartitions (#9
Jackie-Jiang merged PR #9866:
URL: https://github.com/apache/pinot/pull/9866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 03ce7d3bd9 Optimize AdaptiveServerSelection for replicaGroup based
routing (#9803)
add 443b8c542c Clean up transf
Jackie-Jiang merged PR #9858:
URL: https://github.com/apache/pinot/pull/9858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 86f923de45 Support Avro's Fixed data type (#9642)
add 03ce7d3bd9 Optimize AdaptiveServerSelection for replicaG
siddharthteotia merged PR #9803:
URL: https://github.com/apache/pinot/pull/9803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
Jackie-Jiang commented on PR #9832:
URL: https://github.com/apache/pinot/pull/9832#issuecomment-1329930985
Currently `serverReturnFinalResult` is used by v1 engine to return the final
aggregation result instead of the intermediate aggregation result.
The purpose for the flag in this PR is
yupeng9 commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034186559
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Ap
siddharthteotia commented on code in PR #9803:
URL: https://github.com/apache/pinot/pull/9803#discussion_r1034185618
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/ReplicaGroupInstanceSelector.java:
##
@@ -156,4 +159,20 @@ private void
selectServ
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034178740
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to t
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034173776
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##
@@ -50,9 +49,8 @@ abstract class BaseInstanceSelector im
Jackie-Jiang commented on code in PR #9848:
URL: https://github.com/apache/pinot/pull/9848#discussion_r1034165266
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregateFunction.java:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache
Jackie-Jiang commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1034162841
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -33,18 +34,25 @@
public class PartialUpsertHandler {
yupeng9 commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034162491
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Ap
snleee commented on code in PR #9858:
URL: https://github.com/apache/pinot/pull/9858#discussion_r1034159714
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ArrayMaxTransformFunction.java:
##
@@ -38,11 +38,6 @@
public class ArrayMaxTransformFunction
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 86f923de45 Support Avro's Fixed data type (#9642)
sajjad-moradi merged PR #9642:
URL: https://github.com/apache/pinot/pull/9642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.
Jackie-Jiang commented on issue #9865:
URL: https://github.com/apache/pinot/issues/9865#issuecomment-1329878918
Alternatively, we can consider only using fixed length dictionary when all
the values have the same length, use var-length dictionary otherwise. This can
avoid the padding byte sc
Jackie-Jiang commented on issue #8750:
URL: https://github.com/apache/pinot/issues/8750#issuecomment-1329878074
It is already supported if you configure it as `varLengthDictionaryColumns`:
https://docs.pinot.apache.org/configuration-reference/table#table-index-config
Created #9865 to auto
Jackie-Jiang commented on code in PR #9802:
URL: https://github.com/apache/pinot/pull/9802#discussion_r1034146942
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/MemoryOptimizedDimensionTable.java:
##
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Softwa
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034122682
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageStrictReplicaGroupSelector.java:
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to t
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034121640
##
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java:
##
@@ -134,6 +134,10 @@ public InstancePartitions withName(String newName)
Jackie-Jiang commented on PR #9866:
URL: https://github.com/apache/pinot/pull/9866#issuecomment-1329844531
> Do we have the context on why the sort was added at the first place? I'm
good with removing the sort.
It is there in the first version when the feature is added. I think it is
Jackie-Jiang commented on issue #9812:
URL: https://github.com/apache/pinot/issues/9812#issuecomment-1329841751
@vmarchaud We'll probably cut the next release late Dec. or early Jan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Jackie-Jiang commented on PR #9852:
URL: https://github.com/apache/pinot/pull/9852#issuecomment-1329835540
#9857 Added the command for table/schema deletion, so let's just add the
update flag in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message
Jackie-Jiang commented on PR #9857:
URL: https://github.com/apache/pinot/pull/9857#issuecomment-1329834931
Can you please also add some documentation for the new command here:
https://docs.pinot.apache.org/basics/components/table#using-launcher-scripts
You may submit a PR to https://githu
Jackie-Jiang commented on code in PR #9857:
URL: https://github.com/apache/pinot/pull/9857#discussion_r1034110579
##
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##
@@ -236,6 +238,27 @@ public static URI getUploadSchemaURI(String protoc
Jackie-Jiang commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034106995
##
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java:
##
@@ -134,6 +134,10 @@ public InstancePartitions withName(String newName)
etolbakov commented on issue #9847:
URL: https://github.com/apache/pinot/issues/9847#issuecomment-1329818598
hi @snleee
happy to give this ticket a go if no one else is working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jackie-Jiang commented on issue #9793:
URL: https://github.com/apache/pinot/issues/9793#issuecomment-1329813321
Thanks for providing the detailed solution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jackie-Jiang closed issue #9793: Dead server and broker exist in ideal state -
stopping kafka topic ingestion and leaving all tables in bad state
URL: https://github.com/apache/pinot/issues/9793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jackie-Jiang commented on issue #9853:
URL: https://github.com/apache/pinot/issues/9853#issuecomment-1329810699
Good catch. I think `cast` can correctly convert the value to `Timestamp`,
but we don't have the `Literal` expression support on `Timestamp` type, thus
has to store it as string
Jackie-Jiang commented on PR #9804:
URL: https://github.com/apache/pinot/pull/9804#issuecomment-1329793676
In that case, we should make the instance level config accessible from the
`TableDataManager` (through `TableDataManagerConfig`), which is passed into the
`TableUpsertMetadataManager`
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 6ef4dfc500 [multistage] m0ar tests! (binary, boolean, char, time)
(#9818)
add 375b7d0269 [multistage][test] add ta
walterddr merged PR #9817:
URL: https://github.com/apache/pinot/pull/9817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
codecov-commenter commented on PR #9848:
URL: https://github.com/apache/pinot/pull/9848#issuecomment-1329745405
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9848?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
mathieudruart commented on code in PR #9859:
URL: https://github.com/apache/pinot/pull/9859#discussion_r1034020915
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java:
##
@@ -156,11 +174,21 @@
eladar2000 commented on code in PR #9859:
URL: https://github.com/apache/pinot/pull/9859#discussion_r1034019910
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java:
##
@@ -156,11 +174,21 @@ pu
agavra commented on code in PR #9848:
URL: https://github.com/apache/pinot/pull/9848#discussion_r1033928868
##
pinot-query-runtime/src/test/resources/queries/Aggregates.json:
##
@@ -164,85 +117,38 @@
"comments": "class java.lang.Double cannot be cast to class
java.lang
jtao15 commented on PR #9864:
URL: https://github.com/apache/pinot/pull/9864#issuecomment-1329583450
@zhtaoxiang @snleee Correct, the `maxValidBucketEndTimeMs` is only used for
the lowest level.
- For the lowest level, the delay is calculated as (maxValidBucketEndTimeMs
- waterMark)
jtao15 commented on code in PR #9864:
URL: https://github.com/apache/pinot/pull/9864#discussion_r1033921845
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##
@@ -459,7 +
KKcorps commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1033916274
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -65,15 +73,18 @@ public PartialUpsertHandler(Schema schema, Ma
walterddr commented on code in PR #9850:
URL: https://github.com/apache/pinot/pull/9850#discussion_r1033909491
##
pinot-query-runtime/src/test/resources/queries/MathFuncs.json:
##
@@ -0,0 +1,439 @@
+{
+ "addition": {
+"tables": {
+ "numTbl": {
+"schema": [
+
agavra commented on code in PR #9832:
URL: https://github.com/apache/pinot/pull/9832#discussion_r1033909356
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/ServerRequestPlanVisitor.java:
##
@@ -90,6 +92,9 @@ public static ServerPlanRequestContext
build(
walterddr commented on code in PR #9848:
URL: https://github.com/apache/pinot/pull/9848#discussion_r1033905183
##
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactoryTest.java:
##
@@ -444,6 +444,20 @@ public void testGetAggregation
walterddr commented on code in PR #9846:
URL: https://github.com/apache/pinot/pull/9846#discussion_r1033897487
##
pinot-query-runtime/src/test/resources/queries/Case.json:
##
@@ -0,0 +1,71 @@
+{
+ "case_when_test": {
+"tables": {
+ "tbl1": {
+"schema":[
+
walterddr merged PR #9818:
URL: https://github.com/apache/pinot/pull/9818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 837aff94a6 [hotfix] fix type hoisting (#9829)
add 6ef4dfc500 [multistage] m0ar tests! (binary, boolean, char, time)
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 27d4c3ee27 [multistage] [testing] Mailbox receive operator test (#9778)
add 837aff94a6 [hotfix] fix type hoisting (
walterddr merged PR #9829:
URL: https://github.com/apache/pinot/pull/9829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
walterddr commented on issue #9867:
URL: https://github.com/apache/pinot/issues/9867#issuecomment-1329478992
CC @agavra for the 1 less column - i believe this has to do with how the
current pinot-broker reducers expects vs. how calcite expects. thus
pinot-server instance response operator r
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from aa839c97b5 Adding new ADLSPinotFS auth type: DEFAULT (#9860)
add 27d4c3ee27 [multistage] [testing] Mailbox receive
walterddr merged PR #9778:
URL: https://github.com/apache/pinot/pull/9778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
zhtaoxiang commented on PR #9864:
URL: https://github.com/apache/pinot/pull/9864#issuecomment-1329444914
> @zhtaoxiang What's the concern with computing `maxValidBucketEndTimeMs`
for each merge level? Since we are emitting the delay metric per (table, merge
level) pair, I think that we need
agavra commented on code in PR #9850:
URL: https://github.com/apache/pinot/pull/9850#discussion_r1033798740
##
pinot-query-runtime/src/test/resources/queries/MathFuncs.json:
##
@@ -0,0 +1,439 @@
+{
+ "addition": {
+"tables": {
+ "numTbl": {
+"schema": [
+
codecov-commenter commented on PR #9868:
URL: https://github.com/apache/pinot/pull/9868#issuecomment-1328783365
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9868?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
vvivekiyer opened a new pull request, #9868:
URL: https://github.com/apache/pinot/pull/9868
OSS issue: https://github.com/apache/pinot/issues/9348
Label: Feature
[Document](https://docs.google.com/document/d/1Gai0DHBnyR4joG_8AcoR-27_exEBTpVfTFU04HyPdd8/edit#heading=h.liwwtls82n1z)
67 matches
Mail list logo