ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1034173776
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -50,9 +49,8 @@ abstract class BaseInstanceSelector implements
InstanceSelector {
private static final Logger LOGGER =
LoggerFactory.getLogger(BaseInstanceSelector.class);
// To prevent int overflow, reset the request id once it reaches this value
- private static final int MAX_REQUEST_ID = 1_000_000_000;
+ private static final long MAX_REQUEST_ID = 1_000_000_000;
Review Comment:
Technically no, but since I was taking `requestId % MAX_REQUEST_ID` in
`select` and `requestId` is a long there thought of explicitly making it a long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
