amrishlal commented on issue #9820: URL: https://github.com/apache/pinot/issues/9820#issuecomment-1330067945
Discussed briefly with @Jackie-Jiang offline. Jackie mentioned that these proposed changes in `NumericalFilterOptimizer` won't apply to cases where the LHS of the predicate is not DOUBLE (and this can happen currently when functions like `timeConvert` and `arrayLength` are used on LHS). The current plan is to make these changes in `NumericalFilterOptimizer` as interim fixes and then follow up with changes in `PredicateEvaluatorFactory` and `ColumnValueSegmentPruner` that would ultimately allow us to take care of type determination with LHS expressions as well. @Jackie-Jiang Let me know if I am missing anything. cc: @siddharthteotia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
