navina commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1034352337
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##########
@@ -33,18 +34,25 @@
public class PartialUpsertHandler {
// _column2Mergers maintains the mapping of merge strategies per columns.
private final Map<String, PartialUpsertMerger> _column2Mergers = new
HashMap<>();
+ private final UpsertConfig.Strategy _defaultPartialUpsertStrategy;
Review Comment:
`PartialUpsertMergerFactory.getMerger` actually returns the same singleton
instance. So, there is only one merger instance created.
But I can make this change as it get rids of the assumption in the
underlying implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
