[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9702: [bugfix] fix case-when issue

Jackie-Jiang commented on code in PR #9702: URL: https://github.com/apache/pinot/pull/9702#discussion_r1014576988 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java: ## @@ -92,13 +94,40 @@ private static Object coalesceVar(Object... object

[GitHub] [pinot] Jackie-Jiang commented on pull request #9527: Do not create dictionary for high-cardinality columns

Jackie-Jiang commented on PR #9527: URL: https://github.com/apache/pinot/pull/9527#issuecomment-1304412476 In that case, we can keep both `optimizeDictionary` (apply to both dimensions and metrics) and `optimizeDictionaryForMetrics` (only apply to metrics) to avoid backward incompatible. I

[GitHub] [pinot] Jackie-Jiang opened a new issue, #9738: Add sync/async mode when deleting segments

Jackie-Jiang opened a new issue, #9738: URL: https://github.com/apache/pinot/issues/9738 Currently delete segments API delete segments asynchronously (`PinotHelixResourceManager.deleteSegments()`), but delete table API delete segments synchronously (`PinotHelixResourceManager.deleteOfflineT

[GitHub] [pinot] 61yao commented on a diff in pull request #9729: [multistage] [bugfix] Join hash collision

61yao commented on code in PR #9729: URL: https://github.com/apache/pinot/pull/9729#discussion_r1014573953 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -160,17 +164,17 @@ private void consumeInputBlocks() { f

[pinot] branch master updated: [FLaky test] Fix OfflineClusterIntegrationTest.testLiteralOnlyFunc() (#9736)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 34a5c944bd [FLaky test] Fix OfflineClusterIntegr

[GitHub] [pinot] Jackie-Jiang merged pull request #9736: [FLaky test] Fix OfflineClusterIntegrationTest.testLiteralOnlyFunc()

Jackie-Jiang merged PR #9736: URL: https://github.com/apache/pinot/pull/9736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Use ideal state as source of truth for segment existence (#9735)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d530695c57 Use ideal state as source of truth for

[GitHub] [pinot] Jackie-Jiang merged pull request #9735: Use ideal state as source of truth for segment existence

Jackie-Jiang merged PR #9735: URL: https://github.com/apache/pinot/pull/9735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9735: Use ideal state as source of truth for segment existence

Jackie-Jiang commented on code in PR #9735: URL: https://github.com/apache/pinot/pull/9735#discussion_r1014569713 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -730,22 +730,29 @@ public String getActualTableName(St

[GitHub] [pinot] walterddr commented on a diff in pull request #9729: [multistage] [bugfix] Join hash collision

walterddr commented on code in PR #9729: URL: https://github.com/apache/pinot/pull/9729#discussion_r1014569232 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java: ## @@ -44,34 +45,35 @@ * it looks up for the corresponding row(s)

[GitHub] [pinot] walterddr commented on a diff in pull request #9729: [multistage] [bugfix] Join hash collision

walterddr commented on code in PR #9729: URL: https://github.com/apache/pinot/pull/9729#discussion_r1014569124 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -160,17 +164,17 @@ private void consumeInputBlocks() {

[GitHub] [pinot] Jackie-Jiang opened a new issue, #9737: Reverse the stateless and stateful controller tests

Jackie-Jiang opened a new issue, #9737: URL: https://github.com/apache/pinot/issues/9737 Stateless test should represent that the cluster doesn't change the state of the cluster, so it can use a shared cluster setup. Currently we use `stateless` test group for tests that require standalone

[GitHub] [pinot] walterddr commented on a diff in pull request #9735: Use ideal state as source of truth for segment existence

walterddr commented on code in PR #9735: URL: https://github.com/apache/pinot/pull/9735#discussion_r1014568465 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -730,22 +730,29 @@ public String getActualTableName(Strin

[pinot] branch master updated: upgrade RoaringBitmap and revert workaround for bug (#9730)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5e4589e5b8 upgrade RoaringBitmap and revert worka

[GitHub] [pinot] Jackie-Jiang merged pull request #9730: upgrade RoaringBitmap and revert workaround for bug

Jackie-Jiang merged PR #9730: URL: https://github.com/apache/pinot/pull/9730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Fix the server admin endpoint cache to reflect the config changes (#9734)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a3bed7c06d Fix the server admin endpoint cache to

[GitHub] [pinot] Jackie-Jiang merged pull request #9734: Fix the server admin endpoint cache to reflect the config changes

Jackie-Jiang merged PR #9734: URL: https://github.com/apache/pinot/pull/9734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] codecov-commenter commented on pull request #9735: Use ideal state as source of truth for segment existence

codecov-commenter commented on PR #9735: URL: https://github.com/apache/pinot/pull/9735#issuecomment-1304375335 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9735?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on issue #9651: [Flaky test] PinotHelixResourceManagerTest.testSegmentReplacement is flaky

Jackie-Jiang commented on issue #9651: URL: https://github.com/apache/pinot/issues/9651#issuecomment-1304367474 #9735 Should help with the timeout because we no longer need to wait for the segments to be deleted from the property store -- This is an automated message from the Apache Git S

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #9735: Use ideal state as source of truth for segment existence

Jackie-Jiang opened a new pull request, #9735: URL: https://github.com/apache/pinot/pull/9735 When deleting a segment, we delete the segment from ideal state synchronously, then use a separate thread to delete the segment from property store and deep store asynchronously. This could cause i

[GitHub] [pinot] chenboat commented on a diff in pull request #9710: download offline segments from peers

chenboat commented on code in PR #9710: URL: https://github.com/apache/pinot/pull/9710#discussion_r1014531058 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -532,19 +535,44 @@ File downloadAndDecrypt(String segmentName, SegmentZK

[GitHub] [pinot] chenboat commented on a diff in pull request #9710: download offline segments from peers

chenboat commented on code in PR #9710: URL: https://github.com/apache/pinot/pull/9710#discussion_r1014529974 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/instance/InstanceDataManagerConfig.java: ## @@ -66,4 +66,6 @@ public interface InstanceDataManagerConfig { int

[GitHub] [pinot] chenboat commented on a diff in pull request #9710: download offline segments from peers

chenboat commented on code in PR #9710: URL: https://github.com/apache/pinot/pull/9710#discussion_r1014528041 ## pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcherFactory.java: ## @@ -182,6 +183,12 @@ public static void fetchAndDecryptSegmentToLocal(

[GitHub] [pinot] chenboat commented on a diff in pull request #9710: download offline segments from peers

chenboat commented on code in PR #9710: URL: https://github.com/apache/pinot/pull/9710#discussion_r1014527773 ## pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcherFactory.java: ## @@ -20,16 +20,16 @@ import java.io.File; import java.net.URI; -imp

[pinot] 01/01: Add sample code to show how pagination protocol works in broker code

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch test-pagination in repository https://gitbox.apache.org/repos/asf/pinot.git commit 6473c38e1decf1245d8b882fcbd7ca023172c461 Author: Jack Li(Analytics Engineering) AuthorDate: Fri Nov 4 16:39:28 202

[pinot] branch test-pagination updated (1a76a93eea -> 6473c38e1d)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch test-pagination in repository https://gitbox.apache.org/repos/asf/pinot.git discard 1a76a93eea Add sample code to show how pagination protocol works in broker code new 6473c38e1d Add sample

[pinot] 01/01: Add sample code to show how pagination protocol works in broker code

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch test-pagination in repository https://gitbox.apache.org/repos/asf/pinot.git commit 1a76a93eea2d76973272356e1dee270d5d56b800 Author: Jack Li(Analytics Engineering) AuthorDate: Fri Nov 4 16:39:28 202

[pinot] branch test-pagination created (now 1a76a93eea)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch test-pagination in repository https://gitbox.apache.org/repos/asf/pinot.git at 1a76a93eea Add sample code to show how pagination protocol works in broker code This branch includes the follo

[GitHub] [pinot] walterddr commented on a diff in pull request #9731: [multistage] decouple datablock from datatable

walterddr commented on code in PR #9731: URL: https://github.com/apache/pinot/pull/9731#discussion_r1014522408 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] walterddr commented on a diff in pull request #9731: [multistage] decouple datablock from datatable

walterddr commented on code in PR #9731: URL: https://github.com/apache/pinot/pull/9731#discussion_r1014522241 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] agavra commented on a diff in pull request #9731: [multistage] decouple datablock from datatable

agavra commented on code in PR #9731: URL: https://github.com/apache/pinot/pull/9731#discussion_r1014512228 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [pinot] codecov-commenter commented on pull request #9733: show table metadata info in aggregate index size form

codecov-commenter commented on PR #9733: URL: https://github.com/apache/pinot/pull/9733#issuecomment-1304311217 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9733?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] codecov-commenter commented on pull request #9734: Fix the server admin endpoint cache to reflect the config changes

codecov-commenter commented on PR #9734: URL: https://github.com/apache/pinot/pull/9734#issuecomment-1304301697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on issue #9670: Working with new schema registry consuming serialized avro messages

Jackie-Jiang commented on issue #9670: URL: https://github.com/apache/pinot/issues/9670#issuecomment-1304288238 @matthiasValuecloud Currently Pinot is using `5.5.3`, and there is not much dependency change if we upgrade to ` 5.5.12`. Can you please check if the problem can be fixed with `5.

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #9734: Fix the server admin endpoint cache to reflect the config changes

Jackie-Jiang opened a new pull request, #9734: URL: https://github.com/apache/pinot/pull/9734 Currently the server admin endpoints are cached within the controller, but there is no watcher on the instance config changes, which causes the admin endpoint change not reflected. This PR adds

[GitHub] [pinot] agavra commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

agavra commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014474973 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] agavra commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

agavra commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014474973 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] codecov-commenter commented on pull request #9711: [multistage] partial operator chain execution

codecov-commenter commented on PR #9711: URL: https://github.com/apache/pinot/pull/9711#issuecomment-1304264414 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9711?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr opened a new pull request, #9733: show table metadata info in aggregate index size form

walterddr opened a new pull request, #9733: URL: https://github.com/apache/pinot/pull/9733 follow up on #9712 . This PR - show column index size if available instead of just YES and NO - show aggregated column index size (avg) on table metadata API -- This is an automated mess

[GitHub] [pinot] agavra commented on pull request #9711: [multistage] partial operator chain execution

agavra commented on PR #9711: URL: https://github.com/apache/pinot/pull/9711#issuecomment-1304249032 @walterddr just wanted to make sure you don't merge until tests pass, looks like the last commit actually introduced some regressions... double checking that now -- This is an automated m

[GitHub] [pinot] walterddr commented on pull request #9732: [draft] try limit processor count explicitly

walterddr commented on PR #9732: URL: https://github.com/apache/pinot/pull/9732#issuecomment-1304239079 didnt' work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] walterddr closed pull request #9732: [draft] try limit processor count explicitly

walterddr closed pull request #9732: [draft] try limit processor count explicitly URL: https://github.com/apache/pinot/pull/9732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] codecov-commenter commented on pull request #9732: [draft] try limit processor count explicitly

codecov-commenter commented on PR #9732: URL: https://github.com/apache/pinot/pull/9732#issuecomment-1304239237 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9732?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] jadami10 commented on a diff in pull request #9699: UI: re define the segment status

jadami10 commented on code in PR #9699: URL: https://github.com/apache/pinot/pull/9699#discussion_r1014435146 ## pinot-controller/src/main/resources/app/components/SegmentStatusRenderer.tsx: ## @@ -0,0 +1,101 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014430540 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java: ## @@ -137,25 +137,31 @@ public static List reduceMailboxReceive(MailboxRecei

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014429953 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import c

[GitHub] [pinot] agavra commented on a diff in pull request #9711: [multistage] partial operator chain execution

agavra commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014429188 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import com.

[GitHub] [pinot] walterddr commented on issue #8862: Add server api/metrics to track the size of each index in a table

walterddr commented on issue #8862: URL: https://github.com/apache/pinot/issues/8862#issuecomment-1304133488 we can probably model this as a system metadata table (all of these info should be available on server already) -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014415808 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import c

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014414759 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -91,6 +93,7 @@ public AggregateOperator(Operator inputOperat

[GitHub] [pinot] agavra commented on a diff in pull request #9711: [multistage] partial operator chain execution

agavra commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014392934 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java: ## @@ -137,25 +137,31 @@ public static List reduceMailboxReceive(MailboxReceiveO

[GitHub] [pinot] agavra commented on a diff in pull request #9711: [multistage] partial operator chain execution

agavra commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014386219 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java: ## @@ -111,37 +114,46 @@ public String toExplainString() { pro

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014385114 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [pinot] agavra commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

agavra commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014378283 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Found

[pinot] branch master updated: another appraoch (#9712)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9898b913e0 another appraoch (#9712) 9898b913e0 is

[GitHub] [pinot] walterddr merged pull request #9712: add index key and size map to segment metadata

walterddr merged PR #9712: URL: https://github.com/apache/pinot/pull/9712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] agavra commented on a diff in pull request #9711: [multistage] partial operator chain execution

agavra commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014317993 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -91,6 +93,7 @@ public AggregateOperator(Operator inputOperator,

[GitHub] [pinot] npawar commented on a diff in pull request #9712: add index key and size map to segment metadata

npawar commented on code in PR #9712: URL: https://github.com/apache/pinot/pull/9712#discussion_r1014316651 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java: ## @@ -245,6 +248,26 @@ private void init(PropertiesConfiguration

[GitHub] [pinot] walterddr commented on pull request #9712: add index key and size map to segment metadata

walterddr commented on PR #9712: URL: https://github.com/apache/pinot/pull/9712#issuecomment-1303953324 CC @npawar @nizarhejazi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] walterddr commented on a diff in pull request #9712: add index key and size map to segment metadata

walterddr commented on code in PR #9712: URL: https://github.com/apache/pinot/pull/9712#discussion_r1014314067 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java: ## @@ -245,6 +248,26 @@ private void init(PropertiesConfigurati

[GitHub] [pinot] npawar commented on a diff in pull request #9712: add index key and size map to segment metadata

npawar commented on code in PR #9712: URL: https://github.com/apache/pinot/pull/9712#discussion_r1014306434 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java: ## @@ -245,6 +248,26 @@ private void init(PropertiesConfiguration

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014307806 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -44,39 +39,51 @@ /** * + * This class is not thread safe

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014306676 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/OperatorTestUtil.java: ## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014304700 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014304700 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [pinot] walterddr commented on a diff in pull request #9676: [multistage] [bugfix] fix agg hash collision bug

walterddr commented on code in PR #9676: URL: https://github.com/apache/pinot/pull/9676#discussion_r1014304449 ## pinot-query-runtime/pom.xml: ## @@ -91,5 +91,10 @@ h2 test + + org.hamcrest + hamcrest-all + 1.3 + Review Comment: rem

[GitHub] [pinot] 61yao commented on issue #9671: [multi-stage] [stability] QueryDispatcher Grpc needs to have a deadline and should be async

61yao commented on issue #9671: URL: https://github.com/apache/pinot/issues/9671#issuecomment-1303921397 Yeah. not the mailbox one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] walterddr commented on issue #9671: [multi-stage] [stability] QueryDispatcher Grpc needs to have a deadline and should be async

walterddr commented on issue #9671: URL: https://github.com/apache/pinot/issues/9671#issuecomment-1303841462 this is the query stage plan dispatch API yes? not the mailbox data channel? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] walterddr commented on issue #9720: [multistage] [error-handling] MailboxContentStreamObserver poll infinite loop

walterddr commented on issue #9720: URL: https://github.com/apache/pinot/issues/9720#issuecomment-1303838028 _receivingBuffer.poll try catch only catches InterruptedException and all rest of the exception bubbles up. in this case InterruptedException means some manual interrupt (e.g. que

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014154848 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java: ## @@ -149,7 +150,23 @@ public BaseDataBlock.Type getType() { * @

[GitHub] [pinot] agavra commented on a diff in pull request #9711: [multistage] partial operator chain execution

agavra commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014154668 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import com.

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014152556 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import c

[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

walterddr commented on code in PR #9711: URL: https://github.com/apache/pinot/pull/9711#discussion_r1014148282 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -18,28 +18,118 @@ */ package org.apache.pinot.common.datablock; +import c

[GitHub] [pinot] codecov-commenter commented on pull request #9726: [multistage] test restructure

codecov-commenter commented on PR #9726: URL: https://github.com/apache/pinot/pull/9726#issuecomment-1303679821 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr commented on a diff in pull request #9726: [multistage] test restructure

walterddr commented on code in PR #9726: URL: https://github.com/apache/pinot/pull/9726#discussion_r1014098751 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java: ## @@ -127,29 +128,44 @@ protected void addDataToH2(Map> rowsMap) publ

[GitHub] [pinot] walterddr commented on a diff in pull request #9726: [multistage] test restructure

walterddr commented on code in PR #9726: URL: https://github.com/apache/pinot/pull/9726#discussion_r1014098543 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java: ## @@ -157,6 +157,9 @@ private void compareRowEquals(List resultRows, List ex

[GitHub] [pinot] walterddr commented on a diff in pull request #9726: [multistage] test restructure

walterddr commented on code in PR #9726: URL: https://github.com/apache/pinot/pull/9726#discussion_r1014094719 ## pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java: ## @@ -71,4 +98,42 @@ protected Object[][] provideQueries() { +

[GitHub] [pinot] agavra commented on a diff in pull request #9726: [multistage] test restructure

agavra commented on code in PR #9726: URL: https://github.com/apache/pinot/pull/9726#discussion_r1014053700 ## pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java: ## @@ -71,4 +98,42 @@ protected Object[][] provideQueries() { + " b

[GitHub] [pinot] richardstartin opened a new pull request, #9730: upgrade RoaringBitmap and revert workaround for bug

richardstartin opened a new pull request, #9730: URL: https://github.com/apache/pinot/pull/9730 Upgrades RoaringBitmap to get the bug fix from https://github.com/RoaringBitmap/RoaringBitmap/pull/587, reverts workaround introduced in #9453 -- This is an automated message from the Apache G

[pinot] 01/01: upgrade RoaringBitmap and revert workaround for bug

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch rgs/rangebitmap-upgrade-and-fix in repository https://gitbox.apache.org/repos/asf/pinot.git commit 61448cb1588c140239725e5d29afeba1436f1aef Author: Richard Startin AuthorDate: Fri Nov 4 1

[pinot] branch rgs/rangebitmap-upgrade-and-fix created (now 61448cb158)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch rgs/rangebitmap-upgrade-and-fix in repository https://gitbox.apache.org/repos/asf/pinot.git at 61448cb158 upgrade RoaringBitmap and revert workaround for bug This branch includes t

[GitHub] [pinot] rohit-mobstac commented on issue #9553: Wrong controller zookeeper config in "conf/pinot-controller.conf"

rohit-mobstac commented on issue #9553: URL: https://github.com/apache/pinot/issues/9553#issuecomment-1303134407 > @xiangfu0 I have tried `controller.zk.str` and passed the zookeeper ensemble IPs. That doesn’t seem to work either. Does StartController support something like we pass zookeepe