walterddr commented on code in PR #9729:
URL: https://github.com/apache/pinot/pull/9729#discussion_r1014569232
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -44,34 +45,35 @@
* it looks up for the corresponding row(s) from the hash table and create a
joint row.
*
* <p>For each of the data block received from the left table, it will
generate a joint data block.
+ *
+ * We currently support left join, inner join and semi join.
+ * The output is in the format of [left_row, right_row]
*/
public class HashJoinOperator extends BaseOperator<TransferableBlock> {
private static final String EXPLAIN_NAME = "BROADCAST_JOIN";
- private final HashMap<Integer, List<Object[]>> _broadcastHashTable;
+ private final HashMap<Key, List<Object[]>> _broadcastHashTable;
private final Operator<TransferableBlock> _leftTableOperator;
private final Operator<TransferableBlock> _rightTableOperator;
private final JoinRelType _joinType;
private final DataSchema _resultSchema;
- private final DataSchema _leftTableSchema;
- private final DataSchema _rightTableSchema;
private final int _resultRowSize;
private final List<FilterOperand> _joinClauseEvaluators;
private boolean _isHashTableBuilt;
private TransferableBlock _upstreamErrorBlock;
private KeySelector<Object[], Object[]> _leftKeySelector;
private KeySelector<Object[], Object[]> _rightKeySelector;
- public HashJoinOperator(Operator<TransferableBlock> leftTableOperator,
DataSchema leftSchema,
- Operator<TransferableBlock> rightTableOperator, DataSchema rightSchema,
DataSchema outputSchema,
- JoinNode.JoinKeys joinKeys, List<RexExpression> joinClauses, JoinRelType
joinType) {
+ // TODO: Fix inequi join bug.
+ // TODO: Double check semi join logic.
Review Comment:
could you link the github issue url here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
