agavra commented on code in PR #9711:
URL: https://github.com/apache/pinot/pull/9711#discussion_r1014392934
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -137,25 +137,31 @@ public static List<DataTable>
reduceMailboxReceive(MailboxReceiveOperator mailbo
throw new RuntimeException("Received error query execution result
block: "
+ transferableBlock.getDataBlock().getExceptions());
}
+ if (transferableBlock.isNoOpBlock()) {
+ continue;
+ } else if (transferableBlock.isEndOfStreamBlock()) {
+ return resultDataBlocks;
+ }
Review Comment:
hmm, looking at the code I don't think `TransferableBlock#getDataBlock` can
ever return `null` - if the field is null, it either builds the block or throws
an exception, otherwise it returns the field.
I'll remove this check altogether since I think it's just misleading. I
still think we shouldn't be adding to the result table on metadata blocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
