61yao commented on code in PR #9729:
URL: https://github.com/apache/pinot/pull/9729#discussion_r1014573953
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -160,17 +164,17 @@ private void consumeInputBlocks() {
for (int rowId = 0; rowId < numRows; rowId++) {
Object[] row =
SelectionOperatorUtils.extractRowFromDataTable(dataBlock, rowId);
Key key = extraRowKey(row, _groupSet);
- int keyHashCode = key.hashCode();
- _groupByKeyHolder.put(keyHashCode, key.getValues());
- for (int i = 0; i < _aggregationFunctions.length; i++) {
- Object currentRes = _groupByResultHolders[i].get(keyHashCode);
+ _groupByKeyHolder.put(key, key.getValues());
+ for (int i = 0; i < _aggCalls.size(); i++) {
+ Object currentRes = _groupByResultHolders[i].get(key);
+ // TODO: fix that single agg result (original type) has different
type from multiple agg results (double).
Review Comment:
This is one was written on top that since I want to share the test util.
Let me rebase after the merge succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
