xiangfu0 commented on PR #9229:
URL: https://github.com/apache/pinot/pull/9229#issuecomment-1217522700
cc: @gortiz, apparently the Github action takes about 1 hour to install
thrift for arm64 🤕
Base image solution can actually save a lot of time for nightly build.
--
This is an automa
xiangfu0 opened a new pull request, #9229:
URL: https://github.com/apache/pinot/pull/9229
Inspired by
https://github.com/apache/pinot/issues/8718#issuecomment-1172448787
- Add pinot base images for build and runtime
- Update pinot docker build script to pull from base image
-
codecov-commenter commented on PR #9228:
URL: https://github.com/apache/pinot/pull/9228#issuecomment-1217505741
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch add-table-auth-cleanup
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1bf9931a53 add-table refactor for clean auth
add 81812ea006 linter fix
No new revisions were add
KKcorps commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947458038
##
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##
@@ -35,9 +35,16 @@
https://pinot.apache.org/
${basedir}/../../..
-3.11.4
+2.8.1
Review
apucher opened a new pull request, #9228:
URL: https://github.com/apache/pinot/pull/9228
We modify the `AddTable` admin command to use the new-ish `/tableConfigs`
endpoint rather than `/schema` and `/tables` to correct undesirable auth
effect. This enables use-cases where non-admin users ca
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch add-table-auth-cleanup
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 1bf9931a53 add-table refactor for clean auth
This branch includes the following new commits:
ne
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch add-table-auth-cleanup
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 1bf9931a534913b6a137040d032a4e034335ce50
Author: Alexander Pucher
AuthorDate: Tue Aug 16 21:31:53 2022 -
codecov-commenter commented on PR #9227:
URL: https://github.com/apache/pinot/pull/9227#issuecomment-1217293674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
Jackie-Jiang commented on code in PR #9219:
URL: https://github.com/apache/pinot/pull/9219#discussion_r947340298
##
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##
@@ -250,6 +250,9 @@ private BaseFilterOperator
constructPhysicalOperator(FilterContext
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2aa2165367 fix UT failure on explain plan (#9226)
Jackie-Jiang merged PR #9226:
URL: https://github.com/apache/pinot/pull/9226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
codecov-commenter commented on PR #9226:
URL: https://github.com/apache/pinot/pull/9226#issuecomment-1217285450
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
codecov-commenter commented on PR #9225:
URL: https://github.com/apache/pinot/pull/9225#issuecomment-1217270937
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
xiangfu0 opened a new pull request, #9227:
URL: https://github.com/apache/pinot/pull/9227
Refactor stream quickstart
- Move kafkaStarter to QuickstartBase
- Realtime<*>Quickstart should just extend RealtimeQuickstart
- Loading more stream tables
- Refactor hybrid table as well
-
klsince opened a new pull request, #9226:
URL: https://github.com/apache/pinot/pull/9226
fixed UT for explain plan due to a fix added via
https://github.com/apache/pinot/pull/9219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Jackie-Jiang commented on code in PR #9193:
URL: https://github.com/apache/pinot/pull/9193#discussion_r947313065
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/OffsetCriteria.java:
##
@@ -172,17 +196,21 @@ public OffsetCriteria withOffsetString(String
offsetString) {
walterddr commented on code in PR #9219:
URL: https://github.com/apache/pinot/pull/9219#discussion_r947312560
##
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##
@@ -250,6 +250,9 @@ private BaseFilterOperator
constructPhysicalOperator(FilterContext fi
walterddr commented on PR #9219:
URL: https://github.com/apache/pinot/pull/9219#issuecomment-1217251069
this broke ExplainPlanQueriesTest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Jackie-Jiang opened a new pull request, #9225:
URL: https://github.com/apache/pinot/pull/9225
Currently we don't support explicit partition in real-time segment
assignment, which makes it unaligned with the offline segment behavior. This PR
adds support for that, and make the COMPLETED/UPLO
navina opened a new pull request, #9224:
URL: https://github.com/apache/pinot/pull/9224
This is an extension of PR #9096
Most stream systems provide a message envelope, which encapsulates the
record payload, along with record headers, keys and other system-specific
metadata For e.g
navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947298294
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/constant/ConstantMVForwardIndexReader.java:
##
@@ -45,6 +45,9 @@ public DataType g
navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947296365
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##
@@ -85,7 +85,13 @@ public InvertedIn
navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947295408
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##
@@ -85,7 +85,13 @@ public InvertedIn
navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947287042
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##
@@ -966,16 +966,21 @@ public Set getPhysicalColumnNames
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947283582
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,4 +87,22 @@ public BrokerResponse handleRequest(JsonNode
navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947282991
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##
@@ -966,16 +966,21 @@ public Set getPhysicalColumnNames
walterddr commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947279578
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##
@@ -85,7 +85,13 @@ public Inverte
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947277104
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/InstanceUtils.java:
##
@@ -59,6 +60,32 @@ public static String getHelixInstanceId(Instance instance) {
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947277104
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/InstanceUtils.java:
##
@@ -59,6 +60,32 @@ public static String getHelixInstanceId(Instance instance) {
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947274923
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/InstanceUtils.java:
##
@@ -59,6 +60,32 @@ public static String getHelixInstanceId(Instance instance) {
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947273093
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/InstanceUtils.java:
##
@@ -59,6 +60,32 @@ public static String getHelixInstanceId(Instance instance) {
walterddr commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947271979
##
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##
@@ -35,9 +35,16 @@
https://pinot.apache.org/
${basedir}/../../..
-3.11.4
+2.8.1
Revie
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947271960
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -105,6 +117,73 @@ public QueryScheduler(PinotConfiguration config,
QueryExecu
walterddr commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947271606
##
pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml:
##
@@ -35,7 +35,7 @@
${basedir}/../../..
2.8.1
-5.3.1
+5.5.3
Review Comment:
klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r947268749
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -105,6 +117,73 @@ public QueryScheduler(PinotConfiguration config,
QueryExecu
Jackie-Jiang commented on PR #9199:
URL: https://github.com/apache/pinot/pull/9199#issuecomment-1217151941
@yupeng9 True. I discussed this with @ankitsultana and suggested that we may
introduce a flag to mark colocated tables, then we can check the table config
to enforce `numInstancesPerPa
yupeng9 commented on PR #9199:
URL: https://github.com/apache/pinot/pull/9199#issuecomment-1217132894
>
I see whaat you mean. Then that's a reasonable suggestion. But I hope we can
find a way to enforce this as it's not so easy for users to understand the
details to setup colocation
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6fddffe66d make reset table async (#9203)
6fddffe6
walterddr merged PR #9203:
URL: https://github.com/apache/pinot/pull/9203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
walterddr opened a new issue, #9223:
URL: https://github.com/apache/pinot/issues/9223
- [ ] ORDER BY
- [ ] UNNEST
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
walterddr closed issue #9209: [multistage] Support limit properly
URL: https://github.com/apache/pinot/issues/9209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
siddharthteotia commented on PR #9191:
URL: https://github.com/apache/pinot/pull/9191#issuecomment-1217005650
To be rebased on top of https://github.com/apache/pinot/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new da7d534dac Avoid parsing query multiple times (#92
walterddr merged PR #9202:
URL: https://github.com/apache/pinot/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
walterddr commented on PR #9202:
URL: https://github.com/apache/pinot/pull/9202#issuecomment-1216999438
merging and continue refining in https://github.com/apache/pinot/issues/9155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
walterddr commented on PR #9221:
URL: https://github.com/apache/pinot/pull/9221#issuecomment-1216998891
yes I will take a look manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Jackie-Jiang commented on PR #9141:
URL: https://github.com/apache/pinot/pull/9141#issuecomment-1216962076
Replaced with #9171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Jackie-Jiang closed pull request #9141: Initial commit to support cancelling a
long running query (WIP)
URL: https://github.com/apache/pinot/pull/9141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang closed issue #9172: Using text_match on string columns without
text index throw null pointer exception
URL: https://github.com/apache/pinot/issues/9172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7818167fea refine error msg when applying TextMat
Jackie-Jiang merged PR #9219:
URL: https://github.com/apache/pinot/pull/9219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
Jackie-Jiang commented on issue #9188:
URL: https://github.com/apache/pinot/issues/9188#issuecomment-1216922614
I'll close the issue for now. @huaheh Let me know if you run into issues
when trying it out
--
This is an automated message from the Apache Git Service.
To respond to the messag
Jackie-Jiang closed issue #9188: Support to merge the existing column value and
the incoming event
URL: https://github.com/apache/pinot/issues/9188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Jackie-Jiang commented on code in PR #9212:
URL: https://github.com/apache/pinot/pull/9212#discussion_r947046700
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java:
##
@@ -30,11 +31,13 @@
* The manager of the upsert metad
Jackie-Jiang commented on issue #7213:
URL: https://github.com/apache/pinot/issues/7213#issuecomment-1216921160
Are we planning to implement this on the broker side? I'm okay with that as
an initial version, but that won't be the long term solution, and will have a
lot of constraints due to
npawar commented on code in PR #9197:
URL: https://github.com/apache/pinot/pull/9197#discussion_r947039545
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -90,6 +90,23 @@ public Response resumeConsumption(
}
npawar commented on code in PR #9193:
URL: https://github.com/apache/pinot/pull/9193#discussion_r947032176
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java:
##
@@ -63,6 +66,25 @@ public
siddharthteotia commented on PR #9219:
URL: https://github.com/apache/pinot/pull/9219#issuecomment-1216894817
Also, wondering if we should do this on broker as well ?
- For queries with `TEXT_MATCH` on tables that don't have `textIndex`
configured on that column in the `tableConfig`,
KKcorps commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947019952
##
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##
@@ -35,9 +35,16 @@
https://pinot.apache.org/
${basedir}/../../..
-3.11.4
+2.8.1
Review
KKcorps commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947016841
##
pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml:
##
@@ -35,7 +35,7 @@
${basedir}/../../..
2.8.1
-5.3.1
+5.5.3
Review Comment:
I
KKcorps commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r947016203
##
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##
@@ -36,8 +36,17 @@
${basedir}/../../..
3.11.4
Review Comment:
removed
--
This is an au
siddharthteotia commented on PR #9214:
URL: https://github.com/apache/pinot/pull/9214#issuecomment-1216877760
Can we create an issue to track ORDER BY support or may be do it as part of
9209 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f3ff5eb5f0 support limit (#9214)
f3ff5eb5f0 i
siddharthteotia merged PR #9214:
URL: https://github.com/apache/pinot/pull/9214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
dependabot[bot] commented on PR #9221:
URL: https://github.com/apache/pinot/pull/9221#issuecomment-1216872930
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by a
siddharthteotia closed pull request #9221: Bump calcite.version from 1.29.0 to
1.31.0
URL: https://github.com/apache/pinot/pull/9221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
siddharthteotia commented on PR #9221:
URL: https://github.com/apache/pinot/pull/9221#issuecomment-1216872885
I don't think this should be done automatically as it risks breaking changes.
cc @walterddr
--
This is an automated message from the Apache Git Service.
To respond to the m
walterddr opened a new pull request, #9222:
URL: https://github.com/apache/pinot/pull/9222
https://github.com/apache/pinot/issues/9189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
KKcorps commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r946869504
##
pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-ingestion-common/pom.xml:
##
@@ -33,6 +33,12 @@
pinot-ingestion-common
Pinot Ingestion Common
https://p
walterddr commented on code in PR #9203:
URL: https://github.com/apache/pinot/pull/9203#discussion_r946851359
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -2369,143 +2370,137 @@ public void resetSegment(String tab
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/calcite.version-1.31.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 66dd9437c9 Bump calcite.version from 1.29.0 to 1.31.0
No new revisions were added
dependabot[bot] opened a new pull request, #9221:
URL: https://github.com/apache/pinot/pull/9221
Bumps `calcite.version` from 1.29.0 to 1.31.0.
Updates `calcite-core` from 1.29.0 to 1.31.0
Commits
https://github.com/apache/calcite/commit/86d1bf40e4799665951065fd5f4ee4a771e7b6
xiangfu0 commented on code in PR #9220:
URL: https://github.com/apache/pinot/pull/9220#discussion_r946603182
##
pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml:
##
@@ -35,7 +35,7 @@
${basedir}/../../..
2.8.1
-5.3.1
+5.5.3
Review Comment:
S
xiangfu0 commented on issue #8718:
URL: https://github.com/apache/pinot/issues/8718#issuecomment-1216387290
> I've just made an analysis of the docker image.
>
> It seems that the three bigger layers are:
>
> * 344MBs of base image (jdk-slim), which is highly reusable. That mean
codecov-commenter commented on PR #9220:
URL: https://github.com/apache/pinot/pull/9220#issuecomment-1216370333
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
KKcorps opened a new pull request, #9220:
URL: https://github.com/apache/pinot/pull/9220
Currently, the protocol buffer decoder for realtime data only supports file
descriptors. This PR adds support for Confluent Kafka Schema Registry as well.
You can set the following options to read schem
77 matches
Mail list logo
