KKcorps commented on code in PR #9220: URL: https://github.com/apache/pinot/pull/9220#discussion_r947458038
########## pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml: ########## @@ -35,9 +35,16 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/../../..</pinot.root> - <proto.version>3.11.4</proto.version> + <kafka.lib.version>2.8.1</kafka.lib.version> Review Comment: Since we enforce dependency versions in our project, I think it is better to keep everything in root pom.xml so that there's no chance folks can try with a different version in other modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
