[GitHub] [pinot] navina commented on a diff in pull request #9205: Max number of multi values should be set in DefaultNullValueProvider

[GitBox]

navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947287042


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -966,16 +966,21 @@ public Set<String> getPhysicalColumnNames() {
   public DataSource getDataSource(String column) {
     FieldSpec fieldSpec = _schema.getFieldSpecFor(column);
     if (fieldSpec == null || fieldSpec.isVirtualColumn()) {
+      VirtualColumnContext virtualColumnContext = null;
       // Column is either added during ingestion, or was initiated with a 
virtual column provider
       if (fieldSpec == null) {
         // If the column was added during ingestion, we will construct the 
column provider based on its fieldSpec to
         // provide values
         fieldSpec = _newlyAddedColumnsFieldMap.get(column);
         Preconditions.checkNotNull(fieldSpec,
             "FieldSpec for " + column + " should not be null. " + "Potentially 
invalid column name specified.");
+        // newly added column shouldn't have any doc count?
+        virtualColumnContext = new VirtualColumnContext(fieldSpec, 0);

Review Comment:
   yep. old code works fine 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org