[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9212: Add close method to upsert interfaces

[GitBox]

Jackie-Jiang commented on code in PR #9212:
URL: https://github.com/apache/pinot/pull/9212#discussion_r947046700


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java:
##########
@@ -30,11 +31,13 @@
  * The manager of the upsert metadata of a table.
  */
 @ThreadSafe
-public interface TableUpsertMetadataManager {
+public interface TableUpsertMetadataManager extends Closeable {
 
   void init(TableConfig tableConfig, Schema schema, TableDataManager 
tableDataManager, ServerMetrics serverMetrics);
 
   ConcurrentMapPartitionUpsertMetadataManager getOrCreatePartitionManager(int 
partitionId);
 
   UpsertConfig.Mode getUpsertMode();
+
+  void close();

Review Comment:
   Remove this



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -82,4 +83,9 @@ public interface PartitionUpsertMetadataManager {
    * Returns the merged record when partial-upsert is enabled.
    */
   GenericRow updateRecord(GenericRow record, RecordInfo recordInfo);
+
+  /**
+   * Close the partition upsert data manager
+   */
+  void close();

Review Comment:
   Remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org