[pinot] branch cancel-request updated (d66cc7e281 -> 1f412059e5)

2022-07-31 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch cancel-request in repository https://gitbox.apache.org/repos/asf/pinot.git discard d66cc7e281 Initial commit to support cancelling a long running query add 1f412059e5 Initial commit to su

[GitHub] [pinot] kishoreg opened a new pull request, #9141: Initial commit to support cancelling a long running query (WIP)

2022-07-31 Thread GitBox
kishoreg opened a new pull request, #9141: URL: https://github.com/apache/pinot/pull/9141 Some long-running queries will continue to hog resources.. this PR allows users to cancel a query using request id. As of now users need to know the request id. Eventually, we will have the ability to

[pinot] branch cancel-request created (now d66cc7e281)

2022-07-31 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch cancel-request in repository https://gitbox.apache.org/repos/asf/pinot.git at d66cc7e281 Initial commit to support cancelling a long running query This branch includes the following new

[pinot] 01/01: Initial commit to support cancelling a long running query

2022-07-31 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch cancel-request in repository https://gitbox.apache.org/repos/asf/pinot.git commit d66cc7e2815939d6ba462e5182a71e6eff8e4c5a Author: kishoreg AuthorDate: Sun Jul 31 23:50:56 2022 -0700 Initi

[GitHub] [pinot] tanmesh commented on issue #9075: Support extract syntax

2022-07-31 Thread GitBox
tanmesh commented on issue #9075: URL: https://github.com/apache/pinot/issues/9075#issuecomment-1200645865 I am planning to pick this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934055231 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -611,7 +612,11 @@ private void addNewRow(int do

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934049548 ## pinot-core/src/test/java/org/apache/pinot/queries/BooleanNullEnabledQueriesTest.java: ## @@ -194,21 +194,6 @@ public void testQueries() { } } }

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934049636 ## pinot-core/src/test/java/org/apache/pinot/queries/BigDecimalQueriesTest.java: ## @@ -387,54 +387,6 @@ public void testQueries() { assertEquals(row[0], BASE

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934049548 ## pinot-core/src/test/java/org/apache/pinot/queries/BooleanNullEnabledQueriesTest.java: ## @@ -194,21 +194,6 @@ public void testQueries() { } } }

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934048673 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxAggregationFunction.java: ## @@ -28,13 +30,23 @@ import org.apache.pinot.core.query.a

[GitHub] [pinot] sudhindra-hub commented on a diff in pull request #9140: Input format support for reading delta lake tables

2022-07-31 Thread GitBox
sudhindra-hub commented on code in PR #9140: URL: https://github.com/apache/pinot/pull/9140#discussion_r934046155 ## pom.xml: ## @@ -1379,7 +1379,7 @@ com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier} grpc-java

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934033762 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Exp

[GitHub] [pinot] ddcprg closed issue #8624: Unable to select column defined as an array of timestamps

2022-07-31 Thread GitBox
ddcprg closed issue #8624: Unable to select column defined as an array of timestamps URL: https://github.com/apache/pinot/issues/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014682 ## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] codecov-commenter commented on pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
codecov-commenter commented on PR #9126: URL: https://github.com/apache/pinot/pull/9126#issuecomment-1200469880 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9126?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

2022-07-31 Thread GitBox
walterddr commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934016677 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Expre

[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014981 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java: ## @@ -125,16 +126,11 @@ private void sendRequest(TableType tableType

[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014821 ## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014821 ## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

2022-07-31 Thread GitBox
walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014682 ## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] codecov-commenter commented on pull request #9139: Enforce java compilation version in pom

2022-07-31 Thread GitBox
codecov-commenter commented on PR #9139: URL: https://github.com/apache/pinot/pull/9139#issuecomment-1200443133 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9139?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] KKcorps opened a new pull request, #9139: Enforce java compilation version in pom

2022-07-31 Thread GitBox
KKcorps opened a new pull request, #9139: URL: https://github.com/apache/pinot/pull/9139 Currently, when folks try to compile pinot with any other version than java11, they get cryptic error messages. The PR adds check in enforcer plugin and triggers before any compilation happens. e