[GitHub] [pinot] walterddr commented on a diff in pull request #9126: fix grpc query server not setting max inbound msg size

[GitBox]

walterddr commented on code in PR #9126:
URL: https://github.com/apache/pinot/pull/9126#discussion_r934014981


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java:
##########
@@ -125,16 +126,11 @@ private void sendRequest(TableType tableType, 
BrokerRequest brokerRequest,
     }
   }
 
-  // return empty config for now
-  private GrpcQueryClient.Config buildGrpcQueryClientConfig(PinotConfiguration 
config) {
-    return new GrpcQueryClient.Config();

Review Comment:
   This is not correct. config should be passed into the client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org