[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

[GitBox]

walterddr commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r934016677


##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Expression 
thriftExpression) {
    */
   public static FunctionContext getFunction(Function thriftFunction) {
     String functionName = thriftFunction.getOperator();
-    if 
(functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
-      // NOTE: COUNT always take one single argument "*"
-      return new FunctionContext(FunctionContext.Type.AGGREGATION, 
AggregationFunctionType.COUNT.getName(),
-          new 
ArrayList<>(Collections.singletonList(ExpressionContext.forIdentifier("*"))));
-    }

Review Comment:
   the reason why this starts to fail is b/c we removed these. can we keep this 
so the logic is correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org