walterddr commented on code in PR #9126: URL: https://github.com/apache/pinot/pull/9126#discussion_r934014821
########## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.config; + +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.pinot.common.utils.TlsUtils; +import org.apache.pinot.spi.env.PinotConfiguration; + + +public class GrpcConfig { + public static final String GRPC_TLS_PREFIX = "tls"; + public static final String CONFIG_USE_PLAIN_TEXT = "usePlainText"; + public static final String CONFIG_MAX_INBOUND_MESSAGE_BYTES_SIZE = "maxInboundMessageSizeBytes"; + // Default max message size to 128MB + public static final int DEFAULT_MAX_INBOUND_MESSAGE_BYTES_SIZE = 128 * 1024 * 1024; + + private final int _maxInboundMessageSizeBytes; + private final boolean _usePlainText; + private final TlsConfig _tlsConfig; + private final PinotConfiguration _pinotConfig; + + public static GrpcConfig buildGrpcQueryConfig(PinotConfiguration pinotConfig) { + return new GrpcConfig(); Review Comment: actually this is NOT correct! however the `OfflineSecureGRPCServerIntegrationTest` explicitly use the `Map<String, Object>` API to instantiate the GRPC client. thus we are good. Let me also adjust the integration test to make sure this is correctly reflected ########## pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java: ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.config; + +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.pinot.common.utils.TlsUtils; +import org.apache.pinot.spi.env.PinotConfiguration; + + +public class GrpcConfig { + public static final String GRPC_TLS_PREFIX = "tls"; + public static final String CONFIG_USE_PLAIN_TEXT = "usePlainText"; + public static final String CONFIG_MAX_INBOUND_MESSAGE_BYTES_SIZE = "maxInboundMessageSizeBytes"; + // Default max message size to 128MB + public static final int DEFAULT_MAX_INBOUND_MESSAGE_BYTES_SIZE = 128 * 1024 * 1024; + + private final int _maxInboundMessageSizeBytes; + private final boolean _usePlainText; + private final TlsConfig _tlsConfig; + private final PinotConfiguration _pinotConfig; + + public static GrpcConfig buildGrpcQueryConfig(PinotConfiguration pinotConfig) { + return new GrpcConfig(); Review Comment: actually this is NOT correct! the reason why there's no failure is b/c the `OfflineSecureGRPCServerIntegrationTest` explicitly use the `Map<String, Object>` API to instantiate the GRPC client. thus we are good. Let me also adjust the integration test to make sure this is correctly reflected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
