codecov-commenter commented on PR #8975:
URL: https://github.com/apache/pinot/pull/8975#issuecomment-1175802426
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
navina commented on PR #8975:
URL: https://github.com/apache/pinot/pull/8975#issuecomment-1175786462
@KKcorps I have addressed your comment. Can you please commit once the
checks have completed? ty!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
navina commented on code in PR #8975:
URL: https://github.com/apache/pinot/pull/8975#discussion_r914404976
##
pinot-tools/src/main/java/org/apache/pinot/tools/SegmentDumpTool.java:
##
@@ -95,6 +95,7 @@ private void dumpHeader(Schema schema) {
System.out.print(columnName);
walterddr commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914366824
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##
@@ -116,6 +116,8 @@ protected void processTables(Li
walterddr commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914366824
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##
@@ -116,6 +116,8 @@ protected void processTables(Li
npawar commented on PR #8978:
URL: https://github.com/apache/pinot/pull/8978#issuecomment-1175690135
Thanks @satishwaghela . I have last couple of comments
1. After scheduling task using “Schedule Now”, show different message as per
response. If response contains null, show message “C
npawar commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914318161
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##
@@ -116,6 +116,8 @@ protected void processTables(List
codecov-commenter commented on PR #9020:
URL: https://github.com/apache/pinot/pull/9020#issuecomment-1175656247
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9020?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
npawar commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914317759
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1215,12 +1215,18 @@ private void createNewCons
walterddr commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914311851
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##
@@ -116,6 +116,8 @@ protected void processTables(Li
dang-stripe commented on issue #8948:
URL: https://github.com/apache/pinot/issues/8948#issuecomment-1175633803
@Jackie-Jiang Is it possible to make the metadata push job or API call to
block until the segment has successfully been added to idealstate to avoid this
issue? I think the error w
npawar opened a new pull request, #9020:
URL: https://github.com/apache/pinot/pull/9020
Recently saw an exception in RealtimeValidationManager, wherein the
partitionGroupSmallestOffset was returned as null (when trying to fix a segment
which was marked OFFLINE). As a result, the periodic ta
ankitsultana opened a new issue, #9019:
URL: https://github.com/apache/pinot/issues/9019
Around a month ago, we had seen an issue where Pinot brokers for one of our
High QPS use-cases had what looked like a deadlock/livelock related issue. The
brokers were serving traffic around 300-400 QPS
codecov-commenter commented on PR #9006:
URL: https://github.com/apache/pinot/pull/9006#issuecomment-1175603639
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
walterddr commented on code in PR #8981:
URL: https://github.com/apache/pinot/pull/8981#discussion_r914275098
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -269,6 +280,38 @@ public void startController(Map properties)
configA
walterddr commented on code in PR #9006:
URL: https://github.com/apache/pinot/pull/9006#discussion_r914273106
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##
@@ -652,6 +652,29 @@ public Response endRe
rino-kadijk commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r914219956
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##
@@ -45,6 +46,12 @@ public class PinotControllerTr
jadami10 commented on issue #8998:
URL: https://github.com/apache/pinot/issues/8998#issuecomment-1175515605
It seems even after moving the filter condition around and updating to
latest master, this is still happening
--
This is an automated message from the Apache Git Service.
To respond
jadami10 commented on issue #8929:
URL: https://github.com/apache/pinot/issues/8929#issuecomment-1175515116
accidentally duplicated in https://github.com/apache/pinot/issues/9014.
closing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jadami10 closed issue #8929: Allowing empty segments with kafka consumption
URL: https://github.com/apache/pinot/issues/8929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
noon-stripe commented on PR #9018:
URL: https://github.com/apache/pinot/pull/9018#issuecomment-1175511618
label:`bugfix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
noon-stripe opened a new pull request, #9018:
URL: https://github.com/apache/pinot/pull/9018
This PR adds a null check to the SumValueAggregator and adds a unit test to
check this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
walterddr commented on code in PR #9012:
URL: https://github.com/apache/pinot/pull/9012#discussion_r914168777
##
kubernetes/helm/pinot/values.yaml:
##
@@ -305,7 +311,10 @@ server:
nodePort: ""
protocol: TCP
- resources: {}
+ resources:
+requests:
+ cpu: "2
walterddr commented on code in PR #9015:
URL: https://github.com/apache/pinot/pull/9015#discussion_r914166829
##
kubernetes/helm/pinot/values.yaml:
##
@@ -478,7 +486,9 @@ minionStateless:
# Use extraEnv to add individual key value pairs as container environment
variables.
KKcorps commented on issue #9014:
URL: https://github.com/apache/pinot/issues/9014#issuecomment-1175446453
@jadami10 Yeah, in your scenario it makes sense. Yep, we can take it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
walterddr opened a new pull request, #9017:
URL: https://github.com/apache/pinot/pull/9017
context: #8906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
walterddr opened a new issue, #9016:
URL: https://github.com/apache/pinot/issues/9016
- search for ingestion file is hard-coded to recursive, no option to do
non-recursive scan
- glob setting is matching absolute path, which should obviously exclude
part from the root directory
- ing
mcvsubbu commented on issue #9014:
URL: https://github.com/apache/pinot/issues/9014#issuecomment-1175211935
This seems to be a valid use case, and we should be able to support empty
segment commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jadami10 commented on issue #9014:
URL: https://github.com/apache/pinot/issues/9014#issuecomment-1175179709
The problem is that there is data published, and it's quite high volume. We
are just filtering it all out in our decoder. So in this case, the server never
actually commits the segmen
walterddr commented on issue #8906:
URL: https://github.com/apache/pinot/issues/8906#issuecomment-1175171067
looks like ` key = value` is the way to go. implementing it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
walterddr merged PR #8884:
URL: https://github.com/apache/pinot/pull/8884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new de16a0a35d specify how many segments were pruned b
walterddr commented on code in PR #8893:
URL: https://github.com/apache/pinot/pull/8893#discussion_r913887685
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -33,7 +33,49 @@ private RegexpPatternConverterUtils() {
* Convert
jpohanka commented on issue #7137:
URL: https://github.com/apache/pinot/issues/7137#issuecomment-1174952630
@atris Thank you for the fast response, could you pls point to the release ?
I am checking the release notes, but I cannot find the announcement. Thank you.
--
This is an automated
atris commented on issue #7137:
URL: https://github.com/apache/pinot/issues/7137#issuecomment-1174937596
2 was committed and released a couple of versions back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
jpohanka commented on issue #7137:
URL: https://github.com/apache/pinot/issues/7137#issuecomment-1174936409
@atris @Jackie-Jiang Hello, has there been any progress on this ticket ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
KKcorps commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r913612591
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##
@@ -45,6 +46,12 @@ public class PinotControllerTransp
codecov-commenter commented on PR #8979:
URL: https://github.com/apache/pinot/pull/8979#issuecomment-1174733254
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8979?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
rino-kadijk commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r913486229
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##
@@ -45,6 +46,12 @@ public class PinotControllerTr
rino-kadijk commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r913484843
##
pinot-clients/pinot-java-client/src/main/resources/version.properties:
##
@@ -0,0 +1,20 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mo
gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r913463570
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionPartiallyOrderedByOperator.java:
##
@@ -0,0 +1,303 @@
+/**
+ * Licensed to the Apache Software Fou
gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r913463570
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionPartiallyOrderedByOperator.java:
##
@@ -0,0 +1,303 @@
+/**
+ * Licensed to the Apache Software Fou
gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r913456989
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionPartiallyOrderedByOperator.java:
##
@@ -0,0 +1,303 @@
+/**
+ * Licensed to the Apache Software Fou
gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r913456989
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionPartiallyOrderedByOperator.java:
##
@@ -0,0 +1,303 @@
+/**
+ * Licensed to the Apache Software Fou
gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r913454116
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionPartiallyOrderedByOperator.java:
##
@@ -0,0 +1,303 @@
+/**
+ * Licensed to the Apache Software Fou
gortiz commented on code in PR #8893:
URL: https://github.com/apache/pinot/pull/8893#discussion_r913450592
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -33,7 +33,49 @@ private RegexpPatternConverterUtils() {
* Converts a
gortiz commented on code in PR #8893:
URL: https://github.com/apache/pinot/pull/8893#discussion_r913450382
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -33,7 +33,49 @@ private RegexpPatternConverterUtils() {
* Converts a
47 matches
Mail list logo
