walterddr commented on code in PR #9012:
URL: https://github.com/apache/pinot/pull/9012#discussion_r914168777


##########
kubernetes/helm/pinot/values.yaml:
##########
@@ -305,7 +311,10 @@ server:
     nodePort: ""
     protocol: TCP
 
-  resources: {}
+  resources:
+    requests:
+      cpu: "2000m"
+      memory: "1.25Gi"

Review Comment:
   should we set different value for server/minion from broker/controller. the 
usage pattern is drastically different right?



##########
kubernetes/helm/pinot/values.yaml:
##########
@@ -457,7 +469,10 @@ minionStateless:
     protocol: TCP
     name: minion
 
-  resources: {}

Review Comment:
   can't comment below but we should also set zookeeper pod 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to