walterddr commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914311851
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##########
@@ -116,6 +116,8 @@ protected void processTables(List<String>
tableNamesWithType, Properties periodi
processTable(tableNameWithType, context);
} catch (Exception e) {
LOGGER.error("Caught exception while processing table: {} in task:
{}", tableNameWithType, _taskName, e);
+ _controllerMetrics.addMeteredTableValue(tableNameWithType + "." +
_taskName,
+ ControllerMeter.PERIODIC_TASK_ERROR, 1L);
Review Comment:
assuming this will be resolved as
`<table_name>.<OFFLINE|REALTIME>.<TaskName>`? (e.g. tableNameWithType here is
dot-separated)
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1215,12 +1215,18 @@ private void createNewConsumingSegment(TableConfig
tableConfig, PartitionLevelSt
StreamPartitionMsgOffset partitionGroupSmallestOffset =
getPartitionGroupSmallestOffset(streamConfig, partitionGroupId);
- // Start offset must be higher than the start offset of the stream
- if (partitionGroupSmallestOffset.compareTo(startOffset) > 0) {
- LOGGER.error("Data lost from offset: {} to: {} for partition: {} of
table: {}", startOffset,
- partitionGroupSmallestOffset, partitionGroupId,
tableConfig.getTableName());
+ if (partitionGroupSmallestOffset != null) {
+ // Start offset must be higher than the start offset of the stream
+ if (partitionGroupSmallestOffset.compareTo(startOffset) > 0) {
Review Comment:
assuming startOffset is never null yes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
