walterddr commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914366824
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##########
@@ -116,6 +116,8 @@ protected void processTables(List<String>
tableNamesWithType, Properties periodi
processTable(tableNameWithType, context);
} catch (Exception e) {
LOGGER.error("Caught exception while processing table: {} in task:
{}", tableNameWithType, _taskName, e);
+ _controllerMetrics.addMeteredTableValue(tableNameWithType + "." +
_taskName,
+ ControllerMeter.PERIODIC_TASK_ERROR, 1L);
Review Comment:
ok looks like `(\\w+)_(\\w+)` does the resolution to right most (e.g. if
there's underscores in table name, it will make the first `(\\w+)` largest
possible and second `(\\w+)` the smallest matching group).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
