INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845771043
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/BasicAuthAccessControlFactory.java:
##
@@ -50,10 +51,16 @@
private AccessControl _access
kmozaid commented on PR #8255:
URL: https://github.com/apache/pinot/pull/8255#issuecomment-1092476697
Hi @Jackie-Jiang , Could you please provide review feedback? please also
trigger the workflow again.
--
This is an automated message from the Apache Git Service.
To respond to the message
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845764286
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUserRestletResource.java:
##
@@ -0,0 +1,244 @@
+/**
+ * Licensed to the Apache Softwa
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845763208
##
pinot-core/src/main/java/org/apache/pinot/server/access/ZkBasicAuthAccessFactory.java:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
siddharthteotia commented on issue #8493:
URL: https://github.com/apache/pinot/issues/8493#issuecomment-1092451710
Things like histogram, entropy could also be potentially useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
siddharthteotia commented on issue #8493:
URL: https://github.com/apache/pinot/issues/8493#issuecomment-1092450806
@jasperjiaguo , I am unable to assign this to you. So self-assigning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jasperjiaguo commented on issue #8493:
URL: https://github.com/apache/pinot/issues/8493#issuecomment-1092450051
Designing the one request - multiple (sequential) queries model for
statistical functions. Planning to use mini-batch stochastic gradient descent
for regression algorithms.
--
jasperjiaguo opened a new issue, #8493:
URL: https://github.com/apache/pinot/issues/8493
As discussed with @siddharthteotia, consider adding some common statistical
analysis methods SQL language.
Few examples:
1. Pearson's coefficient
2. Linear regression
3. Logistic regress
saurabhd336 commented on PR #8467:
URL: https://github.com/apache/pinot/pull/8467#issuecomment-1092444164
> There is a controller rest API to directly return the live brokers for a
table: `GET /tables/{tableName}/livebrokers`
@Jackie-Jiang But we need all the brokers for all tables wh
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 257f406dd3 Upgrade Helix to 1.0.2
add 4aa4dd9d31 Upgrade Helix to 1.0.2
This update added new revisions after un
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r845736352
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ControllerURLUtils.java:
##
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundati
jackjlli opened a new issue, #8492:
URL: https://github.com/apache/pinot/issues/8492
Currently segment reload/refresh is done asynchronously. There is no way for
Pinot admin to know whether the segment reload/refresh request is fully done on
server side. It could be possible that multiple r
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845705567
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/BasicAuthAccessControlFactory.java:
##
@@ -50,10 +51,16 @@
private AccessControl _access
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845705232
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java:
##
@@ -93,4 +93,17 @@ public void validatePermission(Optional
table
INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r845702999
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/UserConfigUtils.java:
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
xiangfu0 commented on PR #8343:
URL: https://github.com/apache/pinot/pull/8343#issuecomment-1092347020
> Can we add some validation to the `TableConfigUtils.validate()`? The
timestamp index can only be applied to columns with millis granularity
(`TIMESTAMP` data type, or `DATE_TIME` field w
mayankshriv commented on PR #8118:
URL: https://github.com/apache/pinot/pull/8118#issuecomment-1092344581
Thanks @gwenshap for flagging this. Looking at the conversation, it seems
that there were comments from another reviewer that still need to be addressed
before this can be merged. cc: @
npawar commented on code in PR #8455:
URL: https://github.com/apache/pinot/pull/8455#discussion_r845664825
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -1,30 +1,15 @@
-## Description
-
-## Upgrade Notes
-Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Contro
Jackie-Jiang commented on code in PR #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r845659983
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java:
##
@@ -202,6 +207,33 @@ public SegmentGeneratorConfig(TableConfig
Jackie-Jiang commented on issue #8489:
URL: https://github.com/apache/pinot/issues/8489#issuecomment-1092326184
Certain fields should be in ZK metadata only though. Checked the ZK
metadata, and adding start/end offset for debugging purpose should be good
enough. The missing fields are `segm
Jackie-Jiang commented on code in PR #8468:
URL: https://github.com/apache/pinot/pull/8468#discussion_r845649173
##
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValSet.java:
##
@@ -84,6 +85,13 @@
*/
double[] getDoubleValuesSV();
+ /**
+ * Returns the Bi
Jackie-Jiang commented on issue #8477:
URL: https://github.com/apache/pinot/issues/8477#issuecomment-1092320445
The data is available here:
https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/HG7NV7
--
This is an automated message from the Apache Git Service.
To respo
codecov-commenter commented on PR #8491:
URL: https://github.com/apache/pinot/pull/8491#issuecomment-1092304874
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
Jackie-Jiang commented on issue #8474:
URL: https://github.com/apache/pinot/issues/8474#issuecomment-1092291349
We can potentially add an optional id under each scheme to differentiate
credentials. When retrieving the `PinotFS`, user can pass the optional id. If
no id is provided, we keep t
Jackie-Jiang commented on PR #8466:
URL: https://github.com/apache/pinot/pull/8466#issuecomment-1092287657
@atris The problem of allowing `CONTAINS` to use lucene text index is that
we have to use the lucene query syntax for `CONTAINS` which might not be
desired. Also it doesn't add much va
siddharthteotia commented on issue #8164:
URL: https://github.com/apache/pinot/issues/8164#issuecomment-1092283651
The implementation is in progress and is not ready for review
https://github.com/apache/pinot/pull/8434
--
This is an automated message from the Apache Git Service.
To
xiangfu0 commented on PR #8455:
URL: https://github.com/apache/pinot/pull/8455#issuecomment-1092282670
As part of the flow, I feel we can also introduce the ci check on the PR
title/description and fail automatically if any required field is missing.
Example on superset side:
https://githu
xiangfu0 commented on PR #8484:
URL: https://github.com/apache/pinot/pull/8484#issuecomment-1092279112
> Don't we need to write new handlers (java code) for the new grammar ?
Yes, I'm on the java part.
We plan to add the query syntax to insert raw data files into pinot using
t
codecov-commenter commented on PR #8486:
URL: https://github.com/apache/pinot/pull/8486#issuecomment-1092276640
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
Jackie-Jiang opened a new pull request, #8491:
URL: https://github.com/apache/pinot/pull/8491
For issue #8490
## Description
- Add FailureDetector module to the broker
- Add QueryResponse interface
- Add ConnectionFailureDetector to detect server connection failures
##
Jackie-Jiang opened a new issue, #8490:
URL: https://github.com/apache/pinot/issues/8490
We want to add a `FailureDetector` module on the broker to detect the server
failures, and take failed servers out of the routing
Design doc:
https://docs.google.com/document/d/1X32OMT6lC4pCveQVz
klsince commented on code in PR #8486:
URL: https://github.com/apache/pinot/pull/8486#discussion_r845584439
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##
@@ -419,12 +440,17 @@ public SuccessResponse toggleTaskQueueS
npawar commented on issue #8489:
URL: https://github.com/apache/pinot/issues/8489#issuecomment-1092212963
cc: @mayankshriv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
npawar opened a new issue, #8489:
URL: https://github.com/apache/pinot/issues/8489
And any other props that are missing.
Goal: every property in segment zk metadata should be in the metadata file
on the segment.
--
This is an automated message from the Apache Git Service.
To respond t
npawar opened a new issue, #8488:
URL: https://github.com/apache/pinot/issues/8488
The filter config needs a function that evaluates to boolean
https://docs.pinot.apache.org/developers/advanced/ingestion-level-transformations#filtering
So far, we were able to use Groovy for expressing suc
xiangfu0 commented on PR #8465:
URL: https://github.com/apache/pinot/pull/8465#issuecomment-1092180679
@mcvsubbu can you take a look again ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Jackie-Jiang commented on code in PR #8486:
URL: https://github.com/apache/pinot/pull/8486#discussion_r845531899
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##
@@ -213,6 +224,16 @@ public StringResultResponse getTask
walterddr opened a new issue, #8487:
URL: https://github.com/apache/pinot/issues/8487
- `SELECT * FROM t WHERE startsWith(stringCol, 'myStr') = true`
this query works fine
- `SELECT * FROM t WHERE startsWith(stringCol, 'myStr')`
throws exception
```
ProcessingException
klsince opened a new pull request, #8486:
URL: https://github.com/apache/pinot/pull/8486
add endpoints for some finer control on minion tasks:
- inspect the states or configs of the subtasks of a task
- allow to delete individual tasks w/o deleting the task queue
## Description
siddharthteotia commented on PR #8484:
URL: https://github.com/apache/pinot/pull/8484#issuecomment-1092158583
Don't we need to write new handlers (java code) for the new grammar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
codecov-commenter commented on PR #8485:
URL: https://github.com/apache/pinot/pull/8485#issuecomment-1092138816
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
Jackie-Jiang commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r845489285
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ControllerURLUtils.java:
##
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundat
richardstartin closed pull request #8473: Add fine-grained tracing hooks
URL: https://github.com/apache/pinot/pull/8473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 52e5a2c3a6 make tableNameMap always cache list of tables (#8475)
add 6849441b5b add tracing SPI (#8457)
N
richardstartin merged PR #8457:
URL: https://github.com/apache/pinot/pull/8457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
walterddr commented on code in PR #8484:
URL: https://github.com/apache/pinot/pull/8484#discussion_r845399574
##
pinot-common/src/main/codegen/includes/parserImpls.ftl:
##
@@ -0,0 +1,73 @@
+<#--
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contribut
npawar closed issue #7966: Disable query-level Groovy function by default
URL: https://github.com/apache/pinot/issues/7966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
walterddr commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r845247951
##
pinot-common/src/main/proto/plan.proto:
##
@@ -0,0 +1,72 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
MrNeocore commented on PR #6719:
URL: https://github.com/apache/pinot/pull/6719#issuecomment-1091804029
What are the upsides to using TIMESTAMP datatype compared to STRING ? (say
with format `SIMPLE_DATE_FORMAT:-MM-dd`)
--
This is an automated message from the Apache Git Service.
To
MrNeocore commented on PR #7916:
URL: https://github.com/apache/pinot/pull/7916#issuecomment-1091793936
Is `IN_SUBQUERY` inside FILTER supported ?
For example:
`SELECT
SUM(value) FILTER(WHERE IN_SUBQUERY(entityId, 'SELECT ID_SET(entityId)
FROM other_table WHERE cond =
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r845180855
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ControllerBasedBrokerSelector.java:
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Softwa
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r845178107
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PollingBasedBrokerCache.java:
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Fo
richardstartin commented on code in PR #8457:
URL: https://github.com/apache/pinot/pull/8457#discussion_r844950545
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracer.java:
##
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
richardstartin commented on code in PR #8457:
URL: https://github.com/apache/pinot/pull/8457#discussion_r844941314
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/InvocationRecording.java:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
richardstartin commented on code in PR #8457:
URL: https://github.com/apache/pinot/pull/8457#discussion_r844920295
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/InvocationRecording.java:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
richardstartin commented on code in PR #8479:
URL: https://github.com/apache/pinot/pull/8479#discussion_r844833699
##
pinot-common/src/main/proto/plan.proto:
##
@@ -0,0 +1,72 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
56 matches
Mail list logo
