klsince commented on code in PR #8486:
URL: https://github.com/apache/pinot/pull/8486#discussion_r845584439
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##########
@@ -419,12 +440,17 @@ public SuccessResponse toggleTaskQueueState(
@DELETE
@Path("/tasks/{taskType}")
@Authenticate(AccessType.DELETE)
- @ApiOperation("Delete all tasks (as well as the task queue) for the given
task type")
+ @ApiOperation("Delete specified tasks or all the tasks (as well as the task
queue) for the given task type")
Review Comment:
correct, deleting a job requires to stop the task queue firstly; otherwise,
the method throws exception.
yeah, I can start with deleting one task a time for simplicity, and that'd
be enough for most use cases today, because many of our minion tasks stop
scheduling new tasks if there is one still running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
