INNOCENT-BOY commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r845705232
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java: ########## @@ -93,4 +93,17 @@ public void validatePermission(Optional<String> tableNameOpt, AccessType accessT Response.Status.FORBIDDEN); } } + + + public void validatePermission(HttpHeaders httpHeaders, String endpointUrl, + AccessControl accessControl) { + boolean hasPermission; + String accessTypeToEndpintMsg = + String.format("request to the endpioint '%s'", endpointUrl); Review Comment: You are right. I have accepted your advice. It will make this method clearer. Please review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org