npawar commented on code in PR #8455: URL: https://github.com/apache/pinot/pull/8455#discussion_r845664825
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,30 +1,15 @@ -## Description -<!-- Add a description of your PR here. -A good description should include pointers to an issue or design document, etc. ---> -## Upgrade Notes -Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) -* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) - -Does this PR fix a zero-downtime upgrade introduced earlier? -* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) - -Does this PR otherwise need attention when creating release notes? Things to consider: +Instructions: +1. The PR has to be tagged with at least one of the following labels: + 1. `feature` + 2. `bugfix` + 3. `performance` + 4. `ui` + 5. `backward-incompat` + 6. `release-notes` (*) Review Comment: ca we add atleast some of the labels suggested by Richard? I still see only the initial 6. At least testing, refactor, cleanup, else many PRs would simply get tagged as feature/bug-fix even when they're not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
