[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819278835 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -119,4 +130,138 @@ static public Serializable getDefaultValue

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819267921 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@ -53,12 +55,81

[GitHub] [pinot] walterddr opened a new pull request #8293: refactor HttpUtils to pinot-common

2022-03-03 Thread GitBox
walterddr opened a new pull request #8293: URL: https://github.com/apache/pinot/pull/8293 ## Description create HttpUtils out of ControllerTestUtils that are generically useful. ## Release Notes TBA ## Documentation TBA -- This is an automated message from the A

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819266353 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -369,6 +369,9 @@ private static PinotQuery compileCa

[GitHub] [pinot] npawar closed issue #7988: Enhance Pinot Streaming Consumer Interface

2022-03-03 Thread GitBox
npawar closed issue #7988: URL: https://github.com/apache/pinot/issues/7988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] npawar closed issue #4589: Benchmarking for Order By implementations

2022-03-03 Thread GitBox
npawar closed issue #4589: URL: https://github.com/apache/pinot/issues/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819261079 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@ -53,12 +55,81

[GitHub] [pinot] npawar commented on a change in pull request #8233: Add Flink Pinot connector

2022-03-03 Thread GitBox
npawar commented on a change in pull request #8233: URL: https://github.com/apache/pinot/pull/8233#discussion_r819260880 ## File path: pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java ## @@ -0,0 +1,266 @@ +/** +

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819260278 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/GapfillQueriesTest.java ## @@ -0,0 +1,3615 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819259743 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -133,6 +137,8 @@ private QueryContext(String

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819258819 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -31,7 +36,10 @@ */ public class GapfillUtils { private s

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-03 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r817134430 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@ -53,12 +55,82

[GitHub] [pinot] yupeng9 commented on a change in pull request #8233: Add Flink Pinot connector

2022-03-03 Thread GitBox
yupeng9 commented on a change in pull request #8233: URL: https://github.com/apache/pinot/pull/8233#discussion_r819252986 ## File path: pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java ## @@ -0,0 +1,266 @@ +/**

[GitHub] [pinot] yupeng9 commented on a change in pull request #8233: Add Flink Pinot connector

2022-03-03 Thread GitBox
yupeng9 commented on a change in pull request #8233: URL: https://github.com/apache/pinot/pull/8233#discussion_r819142901 ## File path: pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java ## @@ -0,0 +1,88 @@ +/** + * Licen

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8292: Add dateTimeConvert scalar function

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8292: URL: https://github.com/apache/pinot/pull/8292#issuecomment-1058749310 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8292: Add dateTimeConvert scalar function

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8292: URL: https://github.com/apache/pinot/pull/8292#issuecomment-1058749310 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8292: Add dateTimeConvert scalar function

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #8292: URL: https://github.com/apache/pinot/pull/8292#issuecomment-1058749310 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8292: Add dateTimeConvert scalar function

2022-03-03 Thread GitBox
codecov-commenter commented on pull request #8292: URL: https://github.com/apache/pinot/pull/8292#issuecomment-1058749310 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[pinot] branch release-0.10.0-rc created (now fd9c58a)

2022-03-03 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. at fd9c58a Adding NoopPinotMetricFactory and corresponding changes (#8270) No new revisions were added by t

[GitHub] [pinot] walterddr commented on issue #8246: Java client for Controller/Broker/Server REST APIs

2022-03-03 Thread GitBox
walterddr commented on issue #8246: URL: https://github.com/apache/pinot/issues/8246#issuecomment-1058636542 +1 for this proposal. I am also working on factoring out the helper functions from ControllerTestUtils. Here is what I proposed to do, please kindly let me know if this is th

[GitHub] [pinot] Jackie-Jiang opened a new pull request #8291: During rebalance, re-calculate the instance partitions to avoid race condition between 2 rebalances

2022-03-03 Thread GitBox
Jackie-Jiang opened a new pull request #8291: URL: https://github.com/apache/pinot/pull/8291 In no-downtime mode, when the ideal state is changed (potentially by another rebalance request), re-calculate the instance partitions before re-calculating the target assignment. Currently we do

[GitHub] [pinot] icefury71 commented on a change in pull request #8273: Add prefixesToDropFromFields config for renaming fields upon ingestion

2022-03-03 Thread GitBox
icefury71 commented on a change in pull request #8273: URL: https://github.com/apache/pinot/pull/8273#discussion_r819083193 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -279,6 +294,23 @@ prot

[GitHub] [pinot] amrishlal commented on a change in pull request #8029: Add Pre-Aggregation Gapfilling functionality.

2022-03-03 Thread GitBox
amrishlal commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r819020015 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -133,6 +137,8 @@ private QueryContext(String t

[GitHub] [pinot] ksnijjer opened a new issue #8290: Improve error message when aggregate function is applied to a nun-numeric column

2022-03-03 Thread GitBox
ksnijjer opened a new issue #8290: URL: https://github.com/apache/pinot/issues/8290 Pinot currently supports aggregation functions for e.g max() on numeric values only, however if you run a query where a non-numeric column is passed as a value then error message generated is really vague a

[GitHub] [pinot] ksnijjer opened a new issue #8289: Improve error message in Query console on query timeout

2022-03-03 Thread GitBox
ksnijjer opened a new issue #8289: URL: https://github.com/apache/pinot/issues/8289 Currently if any query fired from the Query console times out then below message is shown in the UI: https://user-images.githubusercontent.com/85707391/156644706-8d3d16cc-fbd4-453f-b866-2fd1f8a07c56.p

[GitHub] [pinot] npawar commented on a change in pull request #8233: Add Flink Pinot connector

2022-03-03 Thread GitBox
npawar commented on a change in pull request #8233: URL: https://github.com/apache/pinot/pull/8233#discussion_r819011364 ## File path: pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java ## @@ -0,0 +1,266 @@ +/** +

[GitHub] [pinot] yupeng9 commented on a change in pull request #8233: Add Flink Pinot connector

2022-03-03 Thread GitBox
yupeng9 commented on a change in pull request #8233: URL: https://github.com/apache/pinot/pull/8233#discussion_r818999292 ## File path: pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java ## @@ -0,0 +1,266 @@ +/**

[GitHub] [pinot] xiangfu0 closed issue #8267: Failures during service startup leave process running in an inconsistent state

2022-03-03 Thread GitBox
xiangfu0 closed issue #8267: URL: https://github.com/apache/pinot/issues/8267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[pinot] branch master updated (235e21b -> 46ed731)

2022-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 235e21b Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed (#8272) add 46ed731 Fail process when

[GitHub] [pinot] xiangfu0 merged pull request #8282: Fail process when startup services failing

2022-03-03 Thread GitBox
xiangfu0 merged pull request #8282: URL: https://github.com/apache/pinot/pull/8282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch release-0.10.0 created (now fd9c58a)

2022-03-03 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. at fd9c58a Adding NoopPinotMetricFactory and corresponding changes (#8270) No new revisions were added by this

[GitHub] [pinot] walterddr commented on a change in pull request #7358: [issue-7357] Add support for Avro logical types in realtime ingestion

2022-03-03 Thread GitBox
walterddr commented on a change in pull request #7358: URL: https://github.com/apache/pinot/pull/7358#discussion_r818957908 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroLogicalTypeConversionRegistry.java

[GitHub] [pinot] siddharthteotia commented on issue #8164: Fault domain (Azure) awareness

2022-03-03 Thread GitBox
siddharthteotia commented on issue #8164: URL: https://github.com/apache/pinot/issues/8164#issuecomment-1058362750 @jasperjiaguo and I reviewed the proposal with @Jackie-Jiang Overall we are aligned with the proposed algorithm and there were some questions on implementation details.

[GitHub] [pinot] richardstartin commented on a change in pull request #7358: [issue-7357] Add support for Avro logical types in realtime ingestion

2022-03-03 Thread GitBox
richardstartin commented on a change in pull request #7358: URL: https://github.com/apache/pinot/pull/7358#discussion_r818946683 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroLogicalTypeConversionRegistry.java

[GitHub] [pinot] richardstartin merged pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
richardstartin merged pull request #8272: URL: https://github.com/apache/pinot/pull/8272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pinot] branch master updated (eaf656b -> 235e21b)

2022-03-03 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from eaf656b add more testing for MV var-length columns, detect overflow scenarios (#8286) add 235e21b Fix

[pinot] branch master updated (2edcb6b -> eaf656b)

2022-03-03 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 2edcb6b Upgrade protobuf as the current version has security vulnerability (#8287) add eaf656b add mor

[GitHub] [pinot] richardstartin merged pull request #8286: add more testing for MV var-length columns, detect overflow scenarios

2022-03-03 Thread GitBox
richardstartin merged pull request #8286: URL: https://github.com/apache/pinot/pull/8286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818940174 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ## @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818938704 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ## @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818938704 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ## @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818933915 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ## @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8272: Fix bug in GrpcBrokerRequestHandler: exceptions are suppressed

2022-03-03 Thread GitBox
dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818933764 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ## @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] [pinot] richardstartin commented on a change in pull request #8279: Make realtime indexes pluggable

2022-03-03 Thread GitBox
richardstartin commented on a change in pull request #8279: URL: https://github.com/apache/pinot/pull/8279#discussion_r818921189 ## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/provider/MutableForwardIndexProvider.java ## @@ -0,0 +1,26

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8279: Make realtime indexes pluggable

2022-03-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #8279: URL: https://github.com/apache/pinot/pull/8279#discussion_r818913738 ## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/provider/MutableForwardIndexProvider.java ## @@ -0,0 +1,26 @@

[pinot] branch master updated (e498a71 -> 2edcb6b)

2022-03-03 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from e498a71 move mutable indexes into dedicated package (#8278) add 2edcb6b Upgrade protobuf as the current ver

[GitHub] [pinot] siddharthteotia merged pull request #8287: Upgrade protobuf as the current version has security vulnerability

2022-03-03 Thread GitBox
siddharthteotia merged pull request #8287: URL: https://github.com/apache/pinot/pull/8287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pinot] aashitk opened a new issue #8288: Routes with access_token redirect to home page

2022-03-03 Thread GitBox
aashitk opened a new issue #8288: URL: https://github.com/apache/pinot/issues/8288 After consuming `access_token`, it should redirect to the desired route For instance, `/#/access_token=&query` should redirect to `/#/query` instead of `/#/` -- This is an automated message from the

[GitHub] [pinot] codecov-commenter commented on pull request #8287: Upgrade protobuf as the current version has security vulnerability

2022-03-03 Thread GitBox
codecov-commenter commented on pull request #8287: URL: https://github.com/apache/pinot/pull/8287#issuecomment-1058218276 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] siddharthteotia opened a new pull request #8287: Upgrade protobuf as the current version has security vulnerability

2022-03-03 Thread GitBox
siddharthteotia opened a new pull request #8287: URL: https://github.com/apache/pinot/pull/8287 Our internal build system failed after flagging a security vulenrability in protobuf version com.google.protobuf:protobuf-java:3.17.1 Notes: Vulnerability found and is blocked -- vulner

[GitHub] [pinot] GXM2333 closed issue #8258: MergeRollupTask and RealtimeToOfflineSegmentsTask don't clean up old segments

2022-03-03 Thread GitBox
GXM2333 closed issue #8258: URL: https://github.com/apache/pinot/issues/8258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

[GitHub] [pinot] richardstartin opened a new pull request #8286: add more testing for MV var-length columns, detect overflow scenarios

2022-03-03 Thread GitBox
richardstartin opened a new pull request #8286: URL: https://github.com/apache/pinot/pull/8286 This addresses a bug report of a buffer overflow creating MV string raw forward index, with the following stack trace: ``` Start building IndexCreator! Could not build segment java

[GitHub] [pinot] aashitk opened a new pull request #8285: Fix redirections for routes with access-token

2022-03-03 Thread GitBox
aashitk opened a new pull request #8285: URL: https://github.com/apache/pinot/pull/8285 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-incompat**, an