weixiangsun commented on a change in pull request #8029:
URL: https://github.com/apache/pinot/pull/8029#discussion_r819261079
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java
##########
@@ -53,12 +55,81 @@ private BrokerRequestToQueryContextConverter() {
* Converts the given {@link BrokerRequest} into a {@link QueryContext}.
*/
public static QueryContext convert(BrokerRequest brokerRequest) {
- return brokerRequest.getPinotQuery() != null ? convertSQL(brokerRequest) :
convertPQL(brokerRequest);
+ if (brokerRequest.getPinotQuery() != null) {
+ QueryContext queryContext = convertSQL(brokerRequest.getPinotQuery(),
brokerRequest);
+ queryContext.setGapfillType(GapfillUtils.getGapfillType(queryContext));
Review comment:
The GapfillType is decided when all nested query context(s) are
constructed. It is hard to be decided before each QueryContext is constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
