dongxiaoman commented on a change in pull request #8272: URL: https://github.com/apache/pinot/pull/8272#discussion_r818940174
########## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java ########## @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.reduce; + +import com.google.common.collect.ImmutableMap; +import java.util.Iterator; +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.TimeoutException; +import java.util.function.Function; +import org.apache.pinot.common.proto.Server; +import org.apache.pinot.core.transport.ServerRoutingInstance; +import org.apache.pinot.spi.config.table.TableType; +import org.mockito.invocation.InvocationOnMock; +import org.mockito.stubbing.Answer; +import org.testng.annotations.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; +import static org.testng.Assert.assertTrue; + + +public class StreamingReduceServiceTest { + + @Test + public void testThreadExceptionTransfer() { + // simulate a thread exception in gRPC call and verify that the thread can transfer the exception + Iterator<Server.ServerResponse> mockedResponse = (Iterator<Server.ServerResponse>) mock(Iterator.class); + when(mockedResponse.hasNext()).thenReturn(true); + final String exceptionMessage = "Some exception"; + final RuntimeException innerException = new RuntimeException(exceptionMessage); + when(mockedResponse.next()).thenThrow(innerException); + final ExecutorService threadPoolService = Executors.newFixedThreadPool(1); + final ServerRoutingInstance routingInstance = + new ServerRoutingInstance("localhost", 9527, TableType.OFFLINE, false); + // supposedly we can use TestNG's annotation like @Test(expectedExceptions = { IOException.class }) to verify + // here we hope to verify deeper to make sure the thrown exception is nested inside the exception + assertTrue(verifyException(() -> { + StreamingReduceService.processIterativeServerResponse(mock(StreamingReducer.class), + threadPoolService, + ImmutableMap.of(routingInstance, mockedResponse), + 1000, + mock(BaseReduceService.ExecutionStatsAggregator.class)); + return null; + }, (cause) -> cause.getMessage().contains(exceptionMessage)) + ); + } + + @Test + public void testExecutionTimeout() + throws Exception { + // simulate a thread timeout in gRPC call and verify that the thread can transfer the exception + Iterator<Server.ServerResponse> mockedResponse = (Iterator<Server.ServerResponse>) mock(Iterator.class); + when(mockedResponse.hasNext()).thenReturn(true); + when(mockedResponse.next()).then(new Answer<Void>() { + @Override + public Void answer(InvocationOnMock invocationOnMock) + throws Throwable { + Thread.sleep(1000); + return null; + } + }); + final ExecutorService threadPoolService = Executors.newFixedThreadPool(1); + final ServerRoutingInstance routingInstance = + new ServerRoutingInstance("localhost", 9527, TableType.OFFLINE, false); + // supposedly we can use TestNG's annotation like @Test(expectedExceptions = { IOException.class }) to verify + // here we hope to verify deeper to make sure the thrown exception is nested inside the exception + assertTrue(verifyException(() -> { + StreamingReduceService.processIterativeServerResponse(mock(StreamingReducer.class), + threadPoolService, + ImmutableMap.of(routingInstance, mockedResponse), + 10, + mock(BaseReduceService.ExecutionStatsAggregator.class)); + return null; + }, + (cause) -> cause instanceof TimeoutException)); + } + + private static boolean verifyException(Callable<Void> verifyTarget, Function<Throwable, Boolean> verifyCause) { + boolean exceptionVerified = false; + if (verifyTarget == null || verifyCause == null) { + throw new RuntimeException("verifyException method needs two non-null lambdas"); + } + try { + verifyTarget.call(); + } catch (Exception ex) { + for (Throwable child = ex; + child != null && child.getCause() != child && !exceptionVerified; + child = child.getCause()) { + if (verifyCause.apply(child)) { + exceptionVerified = true; + } Review comment: Thanks. Shorter now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
