[GitHub] [pinot] codecov-commenter edited a comment on pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7935: URL: https://github.com/apache/pinot/pull/7935#issuecomment-997872395 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7935: URL: https://github.com/apache/pinot/pull/7935#issuecomment-997872395 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7935: URL: https://github.com/apache/pinot/pull/7935#issuecomment-997872395 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7935: URL: https://github.com/apache/pinot/pull/7935#issuecomment-997872395 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] suddendust commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-12-20 Thread GitBox
suddendust commented on issue #6679: URL: https://github.com/apache/pinot/issues/6679#issuecomment-998517747 Hi, is there any update on this? We have a use-case wherein we had to update like 22k segments as we migrated our kafka clusters. Doing this manually is not possible (Actually we ha

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7935: URL: https://github.com/apache/pinot/pull/7935#issuecomment-997872395 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] jomach commented on issue #4507: Thirdeye documentation

2021-12-20 Thread GitBox
jomach commented on issue #4507: URL: https://github.com/apache/pinot/issues/4507#issuecomment-998516436 a guide how to perform authentication on kafka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] richardstartin commented on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
richardstartin commented on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-998514155 Notes for merging: this will conflict with #7920 and has been kept separate because I tend to create a PR per change, but both need the benchmark. Once one of the two is me

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-997206576 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-997206576 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] richardstartin commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772857343 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@

[GitHub] [pinot] richardstartin commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772841788 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java ## @@ -425,34 +426,14 @@ void readIntValues(int[] docIds, int l

[GitHub] [pinot] richardstartin commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772841062 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@

[GitHub] [pinot] richardstartin commented on a change in pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7934: URL: https://github.com/apache/pinot/pull/7934#discussion_r772837384 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -65,12 +65,14

[GitHub] [pinot] richardstartin commented on a change in pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7934: URL: https://github.com/apache/pinot/pull/7934#discussion_r772837446 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/FixedByteChunkSVForwardIndexWriter.java ## @@ -112,4 +

[GitHub] [pinot] richardstartin edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
richardstartin edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-998475535 > On a separate note, I saw that originally there were some optimizations piggy-backed to this PR. We should avoid doing that. Each PR should only focus on one featu

[GitHub] [pinot] richardstartin commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772832180 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java ## @@ -82,6 +88,13 @@ default StreamPartitionMsgOffset getNextSt

[GitHub] [pinot] richardstartin commented on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
richardstartin commented on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-998475535 > On a separate note, I saw that originally there were some optimizations piggy-backed to this PR. We should avoid doing that. Each PR should only focus on one feature, one

[GitHub] [pinot] sajjad-moradi commented on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
sajjad-moradi commented on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-998441097 On a separate note, I saw that originally there were some optimizations piggy-backed to this PR. We should avoid doing that. Each PR should only focus on one feature, one bu

[GitHub] [pinot] siddharthteotia commented on issue #7922: SQL MIN/MAX functions produce error when using HAVING without NULL check

2021-12-20 Thread GitBox
siddharthteotia commented on issue #7922: URL: https://github.com/apache/pinot/issues/7922#issuecomment-998431366 The query is not correct. Standard SQL does not support use of HAVING without GROUP BY. Try the examples here for MySQL - https://www.w3schools.com/sql/sql_having.asp

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772771553 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java ## @@ -82,6 +88,13 @@ default StreamPartitionMsgOffset getNextStr

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772769012 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaMessageBatch.java ## @@

[pinot] branch master updated: Move decode method before calling acquireSegment to avoid reference count leak (#7938)

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 58e7f10 Move decode method before calling acquireS

[GitHub] [pinot] jackjlli merged pull request #7938: Move decode method before calling acquireSegment to avoid reference count leak

2021-12-20 Thread GitBox
jackjlli merged pull request #7938: URL: https://github.com/apache/pinot/pull/7938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated: Add instance id in response (#7937)

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 03e8fcb Add instance id in response (#7937) 03e8fc

[GitHub] [pinot] jackjlli merged pull request #7937: Add instance id in response

2021-12-20 Thread GitBox
jackjlli merged pull request #7937: URL: https://github.com/apache/pinot/pull/7937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772769448 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java ## @@ -425,34 +426,14 @@ void readIntValues(int[] docIds, int len

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772765879 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@ pr

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7934: URL: https://github.com/apache/pinot/pull/7934#discussion_r772746860 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/FixedByteChunkSVForwardIndexWriter.java ## @@ -112,4 +11

[pinot] branch master updated (8c50f8a -> eb51880)

2021-12-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 8c50f8a add tooltip and modal for table status (#7899) add eb51880 add simple .asf.yaml (#7738) No new revisi

[GitHub] [pinot] xiangfu0 merged pull request #7738: add simple .asf.yaml

2021-12-20 Thread GitBox
xiangfu0 merged pull request #7738: URL: https://github.com/apache/pinot/pull/7738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang merged pull request #7899: add tooltip and modal for table status

2021-12-20 Thread GitBox
Jackie-Jiang merged pull request #7899: URL: https://github.com/apache/pinot/pull/7899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated: add tooltip and modal for table status (#7899)

2021-12-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8c50f8a add tooltip and modal for table status (

[GitHub] [pinot] Jackie-Jiang commented on issue #7338: Allow reloading segments with multiple threads

2021-12-20 Thread GitBox
Jackie-Jiang commented on issue #7338: URL: https://github.com/apache/pinot/issues/7338#issuecomment-998361997 @Jackie-Jiang I was suggesting to directly use the `_refreshThreadSemaphore` for the reload because `reload` and `refresh` are essentially the same, and we should not have 2 diffe

[pinot] branch add-.asf.yaml updated (a566a3a -> abb03ea)

2021-12-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch add-.asf.yaml in repository https://gitbox.apache.org/repos/asf/pinot.git. from a566a3a add simple .asf.yaml add abb03ea Update .asf.yaml No new revisions were added by this update.

[GitHub] [pinot] codecov-commenter commented on pull request #7938: Move decode method before calling acquireSegment to avoid reference count leak

2021-12-20 Thread GitBox
codecov-commenter commented on pull request #7938: URL: https://github.com/apache/pinot/pull/7938#issuecomment-998354605 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7938?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] walterddr commented on a change in pull request #7921: addking skip key for realtimeToOffline job validation

2021-12-20 Thread GitBox
walterddr commented on a change in pull request #7921: URL: https://github.com/apache/pinot/pull/7921#discussion_r772727875 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -487,15 +492,17 @@ public Suc

[GitHub] [pinot] jackjlli opened a new pull request #7938: Move decode method before calling acquireSegment to avoid reference count leak

2021-12-20 Thread GitBox
jackjlli opened a new pull request #7938: URL: https://github.com/apache/pinot/pull/7938 ## Description This PR moves decode method before calling acquireSegment method in order to avoid reference count leak. Currently if there is issue on decoding, the reference count doesn't get relea

[pinot] 01/01: Move decode method before calling acquireSegment to avoid reference count leak

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-reference-count-for-segments in repository https://gitbox.apache.org/repos/asf/pinot.git commit e9745f10884835332bb237e3a407c9df228e3621 Author: Jack Li(Analytics Engineering) AuthorDate: Mon D

[pinot] branch fix-reference-count-for-segments created (now e9745f1)

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-reference-count-for-segments in repository https://gitbox.apache.org/repos/asf/pinot.git. at e9745f1 Move decode method before calling acquireSegment to avoid reference count leak This

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7918: URL: https://github.com/apache/pinot/pull/7918#discussion_r772589770 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java ## @@ -210,14 +212,15 @@ public String getSegmen

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7928: Small improvements in Docker build

2021-12-20 Thread GitBox
xiangfu0 commented on a change in pull request #7928: URL: https://github.com/apache/pinot/pull/7928#discussion_r772720296 ## File path: docker/images/pinot/docker-build.sh ## @@ -56,6 +56,13 @@ else JAVA_VERSION=8 fi -echo "Trying to build Pinot docker image from Git URL

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7928: Small improvements in Docker build

2021-12-20 Thread GitBox
xiangfu0 commented on a change in pull request #7928: URL: https://github.com/apache/pinot/pull/7928#discussion_r772719993 ## File path: docker/images/pinot/docker-build.sh ## @@ -56,6 +56,13 @@ else JAVA_VERSION=8 fi -echo "Trying to build Pinot docker image from Git URL

[pinot] branch master updated: Update Log4j version to 2.17.0 (#7933)

2021-12-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 93c0404 Update Log4j version to 2.17.0 (#7933)

[GitHub] [pinot] xiangfu0 merged pull request #7933: Update Log4j to 2.17.0 to address CVE-2021-45105

2021-12-20 Thread GitBox
xiangfu0 merged pull request #7933: URL: https://github.com/apache/pinot/pull/7933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7937: Add instance id in response

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7937: URL: https://github.com/apache/pinot/pull/7937#issuecomment-998316919 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7937: Add instance id in response

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7937: URL: https://github.com/apache/pinot/pull/7937#issuecomment-998316919 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7937: Add instance id in response

2021-12-20 Thread GitBox
codecov-commenter commented on pull request #7937: URL: https://github.com/apache/pinot/pull/7937#issuecomment-998316919 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772705714 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] siddharthteotia edited a comment on pull request #7931: don't use mmap for compression except for huge chunks in V4 raw index

2021-12-20 Thread GitBox
siddharthteotia edited a comment on pull request #7931: URL: https://github.com/apache/pinot/pull/7931#issuecomment-998303765 @richardstartin , can we please have a short discussion around raw index. I didn't get a chance to review v4 format and want to be on the same page here w.r.t chang

[GitHub] [pinot] siddharthteotia commented on pull request #7931: don't use mmap for compression except for huge chunks in V4 raw index

2021-12-20 Thread GitBox
siddharthteotia commented on pull request #7931: URL: https://github.com/apache/pinot/pull/7931#issuecomment-998303765 @richardstartin , can we have a short discussion around raw index. I didn't get a chance to review v4 format and want to be on the same page here w.r.t changes / improveme

[GitHub] [pinot] jackjlli opened a new pull request #7937: Add instance id in response

2021-12-20 Thread GitBox
jackjlli opened a new pull request #7937: URL: https://github.com/apache/pinot/pull/7937 ## Description This PR adds instance id at the error message in the response. Currently the response is like below, which is hard to identify the target server: ``` "errors": [

[GitHub] [pinot] siddharthteotia commented on pull request #7920: faster metric scans

2021-12-20 Thread GitBox
siddharthteotia commented on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-998299363 > @siddharthteotia to review before merging. Yes, I will make sure to go through this by EOD. Thank you for waiting -- This is an automated message from the Apache

[pinot] 01/01: Add instance id in response

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-instance-id-in-response in repository https://gitbox.apache.org/repos/asf/pinot.git commit dfaf9e969e27c1b3e45b6f27bbe80110be36f540 Author: Jack Li(Analytics Engineering) AuthorDate: Mon Dec 20

[pinot] branch add-instance-id-in-response created (now dfaf9e9)

2021-12-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-instance-id-in-response in repository https://gitbox.apache.org/repos/asf/pinot.git. at dfaf9e9 Add instance id in response This branch includes the following new commits: new dfa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-997206576 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772666710 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,1

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772666710 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,1

[GitHub] [pinot] richardstartin commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772663250 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] richardstartin commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772663250 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] richardstartin commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772659060 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@

[GitHub] [pinot] richardstartin commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772657590 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] richardstartin commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772657590 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772656228 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7935: exit group-by marking loop early

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7935: URL: https://github.com/apache/pinot/pull/7935#discussion_r772656228 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -270,6 +270,9 @@

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
mcvsubbu commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772655331 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13 @@ pr

[GitHub] [pinot] richardstartin commented on pull request #7920: faster metric scans

2021-12-20 Thread GitBox
richardstartin commented on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-998249346 @siddharthteotia to review before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-997206576 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-997206576 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] richardstartin commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772643897 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,13

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7930: Fix performance problem of base chunk forward index write

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7930: URL: https://github.com/apache/pinot/pull/7930#discussion_r772640243 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java ## @@ -74,15 +71,1

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7934: Power of 2 fixed size chunks

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-997799855 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] richardstartin commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772619331 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -294,15 +300,17 @@ public

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
mcvsubbu commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772617262 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -294,15 +300,17 @@ public void

[GitHub] [pinot] richardstartin commented on issue #7929: Performance problem in segment build

2021-12-20 Thread GitBox
richardstartin commented on issue #7929: URL: https://github.com/apache/pinot/issues/7929#issuecomment-998186011 @sajjad-moradi yes, but it requires field level config. I will open an issue to discuss making it default. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] richardstartin commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772597217 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java ###

[GitHub] [pinot] richardstartin commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772595460 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -294,15 +300,17 @@ public

[GitHub] [pinot] klsince commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
klsince commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772594830 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java ## @@

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7927: URL: https://github.com/apache/pinot/pull/7927#discussion_r772591383 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -294,15 +300,17 @@ public v

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7933: Update Log4j to 2.17.0 to address CVE-2021-45105

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7933: URL: https://github.com/apache/pinot/pull/7933#issuecomment-998167342 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7933: Update Log4j to 2.17.0 to address CVE-2021-45105

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7933: URL: https://github.com/apache/pinot/pull/7933#issuecomment-998167342 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7918: URL: https://github.com/apache/pinot/pull/7918#discussion_r772589770 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java ## @@ -210,14 +212,15 @@ public String getSegmen

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

2021-12-20 Thread GitBox
siddharthteotia commented on a change in pull request #7918: URL: https://github.com/apache/pinot/pull/7918#discussion_r772589770 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java ## @@ -210,14 +212,15 @@ public String getSegmen

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7925: Add help methods to check if segment needs reprocessing

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7925: URL: https://github.com/apache/pinot/pull/7925#issuecomment-997087113 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7925: Add help methods to check if segment needs reprocessing

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7925: URL: https://github.com/apache/pinot/pull/7925#issuecomment-997087113 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7933: Update Log4j to 2.17.0 to address CVE-2021-45105

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7933: URL: https://github.com/apache/pinot/pull/7933#issuecomment-998167342 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] sajjad-moradi commented on issue #7929: Performance problem in segment build

2021-12-20 Thread GitBox
sajjad-moradi commented on issue #7929: URL: https://github.com/apache/pinot/issues/7929#issuecomment-998168662 @richardstartin is V4 currently being used or is to going to be used in future? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pinot] codecov-commenter commented on pull request #7933: Update Log4j to 2.17.0 to address CVE-2021-45105

2021-12-20 Thread GitBox
codecov-commenter commented on pull request #7933: URL: https://github.com/apache/pinot/pull/7933#issuecomment-998167342 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] Jackie-Jiang closed issue #7713: Don't throw exception when query ends with semicolon

2021-12-20 Thread GitBox
Jackie-Jiang closed issue #7713: URL: https://github.com/apache/pinot/issues/7713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated (f27cf0b -> 71fefe2)

2021-12-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from f27cf0b Fix performance problem of base chunk forward index write (#7930) add 71fefe2 Separate the exception f

[GitHub] [pinot] Jackie-Jiang merged pull request #7926: Separate the exception for transform and indexing for consuming records

2021-12-20 Thread GitBox
Jackie-Jiang merged pull request #7926: URL: https://github.com/apache/pinot/pull/7926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7925: Add help methods to check if segment needs reprocessing

2021-12-20 Thread GitBox
codecov-commenter edited a comment on pull request #7925: URL: https://github.com/apache/pinot/pull/7925#issuecomment-997087113 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] richardstartin commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
richardstartin commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772572200 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java ###

[GitHub] [pinot] klsince commented on a change in pull request #7920: faster metric scans

2021-12-20 Thread GitBox
klsince commented on a change in pull request #7920: URL: https://github.com/apache/pinot/pull/7920#discussion_r772569003 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java ## @@

[GitHub] [pinot] richardstartin commented on issue #7929: Performance problem in segment build

2021-12-20 Thread GitBox
richardstartin commented on issue #7929: URL: https://github.com/apache/pinot/issues/7929#issuecomment-998146866 V4 solves the buffer size problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >