Jackie-Jiang commented on a change in pull request #7935:
URL: https://github.com/apache/pinot/pull/7935#discussion_r772765879
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -270,6 +270,9 @@ private void processSingleValue(int numDocs, int[] dictIds,
int[] outGroupIds) {
if (!_flags[outGroupIds[i]]) {
_numKeys++;
_flags[outGroupIds[i]] = true;
+ if (_numKeys == _globalGroupIdUpperBound) {
Review comment:
We should also add one check before the for loop.
Out of the scope of this PR, in `processSingleValueGeneric()` and
`processMultiValue()`, should we move `_flags[groupId] = true` into the if
block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
