richardstartin commented on a change in pull request #7920:
URL: https://github.com/apache/pinot/pull/7920#discussion_r772597217



##########
File path: 
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java
##########
@@ -91,4 +264,8 @@ public double getDouble(int docId, ChunkReaderContext 
context) {
       return _rawData.getDouble(docId * Double.BYTES);
     }
   }
+
+  private boolean isContiguousRange(int[] docIds, int length) {

Review comment:
       OK, got it. However, I think that kind of info would be better off in a 
readme about the how the query and storage layers interact. I can do that 
(because understanding this area of the code has been hard for me) but not in 
this PR. I don't think the comment belongs here, and would be superfluous after 
reading a decent readme.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to