klsince commented on a change in pull request #7920:
URL: https://github.com/apache/pinot/pull/7920#discussion_r772594830
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java
##########
@@ -91,4 +264,8 @@ public double getDouble(int docId, ChunkReaderContext
context) {
return _rawData.getDouble(docId * Double.BYTES);
}
}
+
+ private boolean isContiguousRange(int[] docIds, int length) {
Review comment:
Think I'm lack of some context to understand this new check. Not
necessarily a comment to the code. Would appreciate it if you could shed some
light in the conversion here. Just looking at this check method, I assume it'd
require the docIds to be unique and sorted in asc. So when that happens and
when not. This may help me understand when the optimization can kick in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
