mqliang opened a new pull request #6969:
URL: https://github.com/apache/incubator-pinot/pull/6969
## Description
This PR:
* There is a superset/partial comparison query for realtime table, update
the query result
* Pinot server do some early termination optimization (proce
Jackie-Jiang opened a new pull request #6968:
URL: https://github.com/apache/incubator-pinot/pull/6968
- Replace `GenericRowSerDeUtils` with `GenericRowSerializer` and
`GenericRowDeserailizer` for the following enhancement:
- Support null value fields ser/de to preserve the null fields
codecov-commenter edited a comment on pull request #6942:
URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844313889
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638442247
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##
@@ -227,26 +227,28 @@ public boolean equals(Object ob
xiangfu0 merged pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1efde00 Fixing comparison and hashcod
codecov-commenter edited a comment on pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965#issuecomment-847448970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 2b55004 SegmentDirectoryLoader interface and local impl (#6949)
add 4675b4a Prefetch call to fetch
npawar merged pull request #6967:
URL: https://github.com/apache/incubator-pinot/pull/6967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
codecov-commenter edited a comment on pull request #6967:
URL: https://github.com/apache/incubator-pinot/pull/6967#issuecomment-847502111
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
chenboat commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-847507284
I suppose there is already some offline table segments being pushed to
_tableName_OFFLINE/segmentName_ dir. Do you need to clean them? Or you have
other manual means to cle
codecov-commenter commented on pull request #6967:
URL: https://github.com/apache/incubator-pinot/pull/6967#issuecomment-847502111
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
codecov-commenter edited a comment on pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965#issuecomment-847448970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 848c3d4 Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
add c
codecov-commenter edited a comment on pull request #6942:
URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844313889
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 5e0ce62 Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
add 2
npawar opened a new pull request #6967:
URL: https://github.com/apache/incubator-pinot/pull/6967
Introducing a prefetch call to fetch buffers for columns, based on columns
seen in the queries.
Default implementations are no-op
--
This is an automated message from the Apache Git Servic
sajjad-moradi commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-847470180
@chenboat: I believe it's a safer bet to directly aim for reverting back to
the previous directory structure. This way we prevent any potential issues
that's not yet d
mcvsubbu commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-84747
> The current issue seems to me is primarily about data deletion. We can
first patch the SegmentDeletionManager so that it can deal with segments in
both types of paths (wi
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch detect-invalid-columns
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 8794600 Detect invalid column names from BrokerRequestHandler
add d63d6c5 Fix NPE issue
chenboat commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-847459216
The current issue seems to me is primarily about data deletion. We can first
patch the SegmentDeletionManager so that it can deal with segments in both
types of paths (with
snleee closed issue #6844:
URL: https://github.com/apache/incubator-pinot/issues/6844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
mcvsubbu commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-847457949
> I believe the problem is on `PinotSegmentUploadDownloadRestletResource`
line 295 where `tableNameWithType` is mistakenly passed to the
`getZkDownloadURIForSegmentUpload()
codecov-commenter edited a comment on pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#issuecomment-847452212
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6964?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965#issuecomment-847448970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter commented on pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#issuecomment-847452212
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6964?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
npawar closed issue #6308:
URL: https://github.com/apache/incubator-pinot/issues/6308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
jadami10 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638378230
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##
@@ -227,26 +227,28 @@ public boolean equals(Object ob
codecov-commenter commented on pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965#issuecomment-847448970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
npawar closed issue #6766:
URL: https://github.com/apache/incubator-pinot/issues/6766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
npawar commented on pull request #6873:
URL: https://github.com/apache/incubator-pinot/pull/6873#issuecomment-847446140
Hey @kriti-sc please resolve the merge conflict and fix the test, then i'll
merge this
--
This is an automated message from the Apache Git Service.
To respond to the me
npawar merged pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638367783
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##
@@ -227,26 +227,28 @@ public boolean equals(Object ob
Jackie-Jiang commented on issue #6966:
URL:
https://github.com/apache/incubator-pinot/issues/6966#issuecomment-847431113
I believe the problem is on `PinotSegmentUploadDownloadRestletResource` line
295 where `tableNameWithType` is mistakenly passed to the
`getZkDownloadURIForSegmentUpload
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch deep.store.dir.structure
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 8878df5 Update LICENSE & NOTICE (#6944)
No new revisions were added by this update.
-
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 7394ca7 Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
add 5
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 6bcb850 Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
add 7
sajjad-moradi opened a new issue #6966:
URL: https://github.com/apache/incubator-pinot/issues/6966
The changes introduced in this
[PR](https://github.com/apache/incubator-pinot/pull/6567/files#diff-d0a60155908b7919915de944c49dfad57e2e5e1cc7ad2988176ac090e57567d7R299)
caused the following p
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 34acf9a Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
add 6
xiangfu0 opened a new pull request #6965:
URL: https://github.com/apache/incubator-pinot/pull/6965
## Description
Fixing comparison and hashcode for Schema, FieldSpec and ColumnMetadata.
We missed updating those when adding new fields into the class.
## Upgrade Notes
Does
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 34acf9a Fixing comparison and hashcode for Schema, FieldSpec and
ColumnMetadata
This bran
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch fixing_spi_comparison
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 34acf9aa6c81d73bb4230e639e834f3cfdf095bc
Author: Xiang Fu
AuthorDate: Mon May 24 16:23:44 2021
jadami10 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638348414
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/GenericRowTest.java
##
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache
xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638345602
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##
@@ -227,26 +227,28 @@ public boolean equals(Object ob
npawar commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638344734
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoader.java
##
@@ -0,0 +1,38 @@
+/**
+ * License
npawar commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638344480
##
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerTest.java
##
@@ -34,7 +34,7 @@
import org.apa
kishoreg commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638343437
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoader.java
##
@@ -0,0 +1,38 @@
+/**
+ * Licen
Jackie-Jiang commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638342878
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/GenericRowTest.java
##
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apa
kishoreg commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r636440713
##
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerTest.java
##
@@ -34,7 +34,7 @@
import org.a
jadami10 opened a new pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964
## Description
fixes #6963
GenericRow.compareMap will now return false if the maps are different sizes.
I'm fairly new to this project, so I do not believe this affects up
jadami10 opened a new issue #6963:
URL: https://github.com/apache/incubator-pinot/issues/6963
I believe this was a subtle bug introduced in #6525. The current code
structure is
```
if (thisMap.size() == thatMap.size()) {
...
}
return true
```
If a GenericRow has a dif
npawar commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638322812
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoaderRegistry.java
##
@@ -0,0 +1,89 @@
+/**
+ *
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 9adbe55 Include complex-type-handling quickstarts in the assembler
(#6961)
add 8878df5 Update LICENSE
snleee merged pull request #6944:
URL: https://github.com/apache/incubator-pinot/pull/6944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
Jackie-Jiang commented on issue #6962:
URL:
https://github.com/apache/incubator-pinot/issues/6962#issuecomment-847324558
This happens when all the segments are pruned out, and Pinot server
short-circuits the query to directly return without checking the schema. We
should just not return t
mayankshriv commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638229702
##
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoaderRegistry.java
##
@@ -0,0 +1,89 @@
+/*
sajjad-moradi opened a new issue #6962:
URL: https://github.com/apache/incubator-pinot/issues/6962
**Non-empty results (correct types):**
**Empty results (incorrect types
This is an automated email from the ASF dual-hosted git repository.
yupeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9adbe55 Include complex-type-handling
yupeng9 merged pull request #6961:
URL: https://github.com/apache/incubator-pinot/pull/6961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 958b4d4 Enabling compatibility tests
mcvsubbu merged pull request #6959:
URL: https://github.com/apache/incubator-pinot/pull/6959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
apucher closed pull request #6933:
URL: https://github.com/apache/incubator-pinot/pull/6933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
codecov-commenter edited a comment on pull request #6961:
URL: https://github.com/apache/incubator-pinot/pull/6961#issuecomment-847209188
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1209bcc Use stored types instead of de
Jackie-Jiang merged pull request #6960:
URL: https://github.com/apache/incubator-pinot/pull/6960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
codecov-commenter commented on pull request #6961:
URL: https://github.com/apache/incubator-pinot/pull/6961#issuecomment-847209188
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
codecov-commenter edited a comment on pull request #6960:
URL: https://github.com/apache/incubator-pinot/pull/6960#issuecomment-846493497
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6960?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
yupeng9 opened a new pull request #6961:
URL: https://github.com/apache/incubator-pinot/pull/6961
## Description
Part of https://github.com/apache/incubator-pinot/issues/6904
Include complex-type-handling quickstart examples in the assembler
--
This is an automated message f
amrishlal commented on a change in pull request #6960:
URL: https://github.com/apache/incubator-pinot/pull/6960#discussion_r638092754
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java
##
@@ -28
mqliang commented on a change in pull request #6959:
URL: https://github.com/apache/incubator-pinot/pull/6959#discussion_r638087258
##
File path: compatibility-verifier/compCheck.sh
##
@@ -48,27 +50,62 @@ function usage() {
}
function waitForZkReady() {
- # TODO: check ZK
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 71e156c Make Pinot Broker/Server/Mini
xiangfu0 merged pull request #5446:
URL: https://github.com/apache/incubator-pinot/pull/5446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
codecov-commenter edited a comment on pull request #5446:
URL: https://github.com/apache/incubator-pinot/pull/5446#issuecomment-845514923
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
73 matches
Mail list logo
