npawar commented on a change in pull request #6949: URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r638344480
########## File path: pinot-broker/src/test/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerTest.java ########## @@ -34,7 +34,7 @@ import org.apache.helix.model.IdealState; import org.apache.helix.store.zk.ZkHelixPropertyStore; import org.apache.pinot.common.metadata.ZKMetadataProvider; -import org.apache.pinot.common.metadata.segment.ColumnPartitionMetadata; +import org.apache.pinot.segment.spi.partition.ColumnPartitionMetadata; Review comment: I didn't create a new one. It already existed. `PartitionFunction` was in the package. It also was the logical place for these classes to move, which used to be in `org.apache.pinot.segment.local.partition` ``` MurmurPartitionFunction.java ModuloPartitionFunction.java HashPartitionFunction.java ByteArrayPartitionFunction.java PartitionFunctionFactory.java ``` The ColumnPartitionMetadata is also only relevant to partition. I can put it in `metadata` package under this if that's better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org