jadami10 commented on a change in pull request #6964: URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638348414
########## File path: pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/GenericRowTest.java ########## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data.readers; + +import org.testng.Assert; +import org.testng.annotations.Test; + +public class GenericRowTest { Review comment: Good idea, added a few more tests. ########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ########## @@ -227,26 +227,28 @@ public boolean equals(Object obj) { } private boolean compareMap(Map<String, Object> thisMap, Map<String, Object> thatMap) { - if (thisMap.size() == thatMap.size()) { - for (String key : thisMap.keySet()) { - Object fieldValue = thisMap.get(key); - Object thatFieldValue = thatMap.get(key); - if (fieldValue == null) { - if (thatFieldValue != null) { - return false; - } - } else if (!fieldValue.equals(thatFieldValue)) { - if (fieldValue instanceof Map && thatFieldValue instanceof Map) { - return compareMap((Map<String, Object>) fieldValue, (Map<String, Object>) thatFieldValue); - } - if ((fieldValue instanceof byte[]) && (thatFieldValue instanceof byte[])) { - return Arrays.equals((byte[]) fieldValue, (byte[]) thatFieldValue); - } - if (fieldValue.getClass().isArray() && thatFieldValue.getClass().isArray()) { - return compareArray((Object[]) fieldValue, (Object[]) thatFieldValue); - } + if (thisMap.size() != thatMap.size()) { Review comment: is it possible for these to be null? If os, what would the desired behavior be here? Only return true if they're both null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
