jadami10 opened a new issue #6963:
URL: https://github.com/apache/incubator-pinot/issues/6963


   I believe this was a subtle bug introduced in #6525. The current code 
structure is
   ```
   if (thisMap.size() == thatMap.size()) {
     ...
   }
   return true
   ```
   If a GenericRow has a different number of fields, this always returns true. 
I don't believe this was the intention in that change. Previously it was doing 
`return _fieldToValueMap.equals(that._fieldToValueMap) && 
_nullValueFields.equals(that._nullValueFields);` which returns false on size 
differences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to