[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#issuecomment-844477784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635756076 ## File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json ## @@ -

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#issuecomment-844477784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (c431653 -> fe5527c)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c431653 Make Pinot Broker/Server/Minion can start by just passing a

[GitHub] [incubator-pinot] xiangfu0 commented on issue #6948: Pinot ui can't show all the pinot servers

2021-05-19 Thread GitBox
xiangfu0 commented on issue #6948: URL: https://github.com/apache/incubator-pinot/issues/6948#issuecomment-844670373 @shahsank3t -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #5446: Make Pinot Broker/Server/Minion can start by just passing a config file

2021-05-19 Thread GitBox
xiangfu0 commented on a change in pull request #5446: URL: https://github.com/apache/incubator-pinot/pull/5446#discussion_r635735037 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java ## @@ -102,25 +101,43 @@ // Participant

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #5446: Make Pinot Broker/Server/Minion can start by just passing a config file

2021-05-19 Thread GitBox
xiangfu0 commented on a change in pull request #5446: URL: https://github.com/apache/incubator-pinot/pull/5446#discussion_r635734497 ## File path: pinot-tools/src/main/resources/conf/pinot-broker.conf ## @@ -0,0 +1,33 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
yupeng9 commented on a change in pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#discussion_r635727010 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java ## @@ -134,1

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
yupeng9 commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635724348 ## File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json ## @@ -26,23 +2

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6947: Move TableDataManager to segment-local to unblock partial upsert feature

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6947: URL: https://github.com/apache/incubator-pinot/pull/6947#issuecomment-844569431 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5446: Make Pinot Broker/Server/Minion can start by just passing a config file

2021-05-19 Thread GitBox
mayankshriv commented on a change in pull request #5446: URL: https://github.com/apache/incubator-pinot/pull/5446#discussion_r635707579 ## File path: pinot-tools/src/main/resources/conf/pinot-broker.conf ## @@ -0,0 +1,33 @@ +// +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
Jackie-Jiang commented on pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844634434 I'd strongly recommend short circuit the query on broker without sending it to servers. On server side all segments will be pruned and the result will be the same a

[incubator-pinot] branch master updated: Fix the exception thrown in the case that a specified table name does not exist (#6328) (#6765)

2021-05-19 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 7b44624 Fix the exception thrown in th

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6765: Fix the exception thrown when the table is not found

2021-05-19 Thread GitBox
Jackie-Jiang merged pull request #6765: URL: https://github.com/apache/incubator-pinot/pull/6765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] npawar opened a new pull request #6949: WIP - SegmentDirectoryLoader interface and local impl

2021-05-19 Thread GitBox
npawar opened a new pull request #6949: URL: https://github.com/apache/incubator-pinot/pull/6949 Not ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#issuecomment-844477784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635687192 ## File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json ## @@ -

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6947: Move TableDataManager to segment-local to unblock partial upsert feature

2021-05-19 Thread GitBox
Jackie-Jiang commented on pull request #6947: URL: https://github.com/apache/incubator-pinot/pull/6947#issuecomment-844623761 @mcvsubbu `segment-spi` is supposed to be used by the `query-spi` (not introduced yet) to provide the storage layer of the segment. Since we haven't introduce the `

[GitHub] [incubator-pinot] cxing opened a new issue #6948: Pinot ui can't show all the pinot servers

2021-05-19 Thread GitBox
cxing opened a new issue #6948: URL: https://github.com/apache/incubator-pinot/issues/6948 We have 30 server clusters but this ui just show 10 ![image](https://user-images.githubusercontent.com/13634486/118905765-f392bd80-b94e-11eb-997b-539ae5f2a51e.png) -- This is an automated me

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#discussion_r635685922 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java ## @

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
yupeng9 commented on a change in pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#discussion_r635673571 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java ## @@ -134,1

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (056a3b0 -> c431653)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 056a3b0 Make Pinot Broker/Server/Minion can start by just passing a

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6945: Add the complex-type support to decoder/reader

2021-05-19 Thread GitBox
yupeng9 commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635672397 ## File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json ## @@ -26,23 +2

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (36e584e -> 056a3b0)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 36e584e Make Pinot Broker/Server can start by just passing a config

[GitHub] [incubator-pinot] liuchang0520 commented on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
liuchang0520 commented on pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-844591248 > Please replaces the `isExceededMaxTime` call with a different one like discussed Replaced with `isExceededMinTimeToFixSegmentStoreCopy` -- This is an aut

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r635668786 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r635668519 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r635668519 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-19 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r635667690 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java ## @@ -100,6 +100,

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (6f283bd -> 36e584e)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6f283bd Make Pinot Broker/Server can start by just passing a config

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6945: Add the complex-type support to

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635663425 ## File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json ## @@ -

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#discussion_r635660091 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java ## @

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (8aead7a -> 6f283bd)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8aead7a Make Pinot Broker/Server can start by just passing a config

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6947: Move TableDataManager to segment-local to unblock partial upsert feature

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #6947: URL: https://github.com/apache/incubator-pinot/pull/6947#issuecomment-844569431 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6947: Move TableDataManager to segment-local to unblock partial upsert feature

2021-05-19 Thread GitBox
Jackie-Jiang opened a new pull request #6947: URL: https://github.com/apache/incubator-pinot/pull/6947 - Move `SegmentDataManager` to `pinot-segment-spi` - Move `TableDataManager` and `TableDataManagerConfig` to `pinot-segment-local` - Ideally they should go to `pinot-segment-spi` a

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#issuecomment-844523160 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-19 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635621036 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION, QUERY

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-19 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635619758 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java ## @@ -102,8 +103,17 @

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-19 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635619654 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION, QUERY

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (f329659 -> 8aead7a)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f329659 Adding more config alias discard 974fe0f Make Pinot Broker/

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (6128b75 -> f329659)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6128b75 Adding more config alias add f329659 Adding more config

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946#issuecomment-844523160 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[incubator-pinot] branch add-two-broker-metrics updated (008a925 -> 0fc2da3)

2021-05-19 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-two-broker-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 008a925 Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics add 0f

[GitHub] [incubator-pinot] MacNale commented on issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
MacNale commented on issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943#issuecomment-844491249 Disconnected from VPN and ran the command from my mac. It worked fine. This seems to be a problem with downloading the stream from meetup.com. -- This is an automated mess

[GitHub] [incubator-pinot] MacNale closed issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
MacNale closed issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635587341 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION,

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6946: Add collectionToJsonMode to schema inference

2021-05-19 Thread GitBox
yupeng9 opened a new pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946 Part of https://github.com/apache/incubator-pinot/issues/6904 ## Description Add collectionToJsonMode to schema inference to be consistent with the Complex-type config -

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
amrishlal commented on a change in pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#discussion_r635595775 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -1682,6 +1685,74 @@ static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6945: Add the complex-type support to

2021-05-19 Thread GitBox
Jackie-Jiang commented on a change in pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635585801 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -145,6 +1

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635587341 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION,

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
amrishlal commented on a change in pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#discussion_r635581806 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/QueryValidationTest.java ## @@ -131,10 +136,68 @@ private void

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6945: Add the complex-type support to

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#issuecomment-844477784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844313889 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6945: Add the complex-type support to

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945#issuecomment-844477784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6944: Update LICENSE & NOTICE

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6944: URL: https://github.com/apache/incubator-pinot/pull/6944#issuecomment-844434134 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6944?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6945: Add the complex-type support to

2021-05-19 Thread GitBox
yupeng9 opened a new pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945 ## Description Add the complex-type support in the decoder/reader for realtime/offline ingestion. So the fields to read will parse path with complex-type and read the fields accordingly.

[incubator-pinot] branch master updated: add command to infer pinot schema from json data (#6930)

2021-05-19 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6f4790f add command to infer pinot sch

[GitHub] [incubator-pinot] yupeng9 merged pull request #6930: add command to infer pinot schema from json data

2021-05-19 Thread GitBox
yupeng9 merged pull request #6930: URL: https://github.com/apache/incubator-pinot/pull/6930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6944: Update LICENSE & NOTICE

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #6944: URL: https://github.com/apache/incubator-pinot/pull/6944#issuecomment-844434134 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6944?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] xiangfu0 commented on issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
xiangfu0 commented on issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943#issuecomment-844408493 have you tried with `quick-start-hybrid.sh` and if that one works? Also, check if you can run the below command directly: ``` websocat wss://stream.meetup.com/2/rsvp

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844313889 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] snleee commented on pull request #6944: Update LICENSE & NOTICE

2021-05-19 Thread GitBox
snleee commented on pull request #6944: URL: https://github.com/apache/incubator-pinot/pull/6944#issuecomment-844398280 @felixcheung @olamy @kishoreg Pinot mentors, can you review the license change above? Thank you! -- This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-pinot] snleee commented on pull request #6944: Update LICENSE & NOTICE

2021-05-19 Thread GitBox
snleee commented on pull request #6944: URL: https://github.com/apache/incubator-pinot/pull/6944#issuecomment-844397271 #6785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [incubator-pinot] snleee opened a new pull request #6944: Update LICENSE & NOTICE

2021-05-19 Thread GitBox
snleee opened a new pull request #6944: URL: https://github.com/apache/incubator-pinot/pull/6944 The major code change in the UI(#5684) removed all the bundled javascript/css files. This change removed bunch of copied js/css files but the pr did not correctly address the license.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
mcvsubbu commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635484008 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java ## @@ -102,8 +103,17 @

[GitHub] [incubator-pinot] apucher commented on issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
apucher commented on issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943#issuecomment-844358954 this looks like a ssl-handshake issue with the meetup provider. not related to pinot internals -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635481739 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION, QUERY

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6930: add command to infer pinot schema from json data

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6930: URL: https://github.com/apache/incubator-pinot/pull/6930#issuecomment-842722553 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635478989 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java ## @@ -30,6 +30,8 @@ QUERY_EXECUTION, QUERY

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add SERVER_PROCESSING and NETTY_CONNECTION to broker query phase metrics

2021-05-19 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635472281 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -81,5 +86,7 @@ void receiveDataTable(Dat

[incubator-pinot] branch master updated (57c1603 -> fe322f5)

2021-05-19 Thread cpsoman
This is an automated email from the ASF dual-hosted git repository. cpsoman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 57c1603 Fix CAST transform function for chained transforms (#6941) add fe322f5 Adding a new Controll

[GitHub] [incubator-pinot] icefury71 merged pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

2021-05-19 Thread GitBox
icefury71 merged pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-844313889 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] mayankshriv commented on issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
mayankshriv commented on issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943#issuecomment-844312156 Tried `pinot-tools/target/pinot-tools-pkg/bin/quick-start-streaming.sh` with latest master and could not reproduce the issue. Are you on VPN @MacNale that might be causi

[GitHub] [incubator-pinot] mayankshriv commented on issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
mayankshriv commented on issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943#issuecomment-844306804 From the log it seems to use 0.8.0 and not 0.7.1 (which is working for us). -- This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-pinot] branch master updated (1b0bb72 -> 57c1603)

2021-05-19 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1b0bb72 Update Quickstart to take tmp dir as a parameter (#5445) add 57c1603 Fix CAST transform funct

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6941: Fix CAST transform function for chained transforms

2021-05-19 Thread GitBox
Jackie-Jiang merged pull request #6941: URL: https://github.com/apache/incubator-pinot/pull/6941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6930: add command to infer pinot schema from json data

2021-05-19 Thread GitBox
yupeng9 commented on a change in pull request #6930: URL: https://github.com/apache/incubator-pinot/pull/6930#discussion_r635436121 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java ## @@ -380,4 +389,120 @@ private static void unnestResults(List> c

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

2021-05-19 Thread GitBox
npawar commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r635426521 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +134,51 @@ private Stri

[GitHub] [incubator-pinot] MacNale opened a new issue #6943: Stream Quickstart 0.7.1 fails with SSL Handshake failed error

2021-05-19 Thread GitBox
MacNale opened a new issue #6943: URL: https://github.com/apache/incubator-pinot/issues/6943 `docker run --network=pinot-demo --name pinot-quickstart -p 9000:9000 -d apachepinot/pinot:test QuickStart -type stream` ![image](https://user-images.githubusercontent.com/14

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-19 Thread GitBox
jackjlli opened a new pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942 ## Description This PR detects invalid column names from SQL query in BrokerRequestHandler. If invalid column names are detected from a SQL query, a broker metric would be emitted for ba

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

2021-05-19 Thread GitBox
mcvsubbu commented on pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-844273786 > > > @icefury71 @npawar > > > To avoid creating multiple debug api's on servers, I propose to consolidate the one I am creating for segments as follows: > > >

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

2021-05-19 Thread GitBox
mcvsubbu commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r635404113 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +134,51 @@ private St

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6941: Fix CAST transform function for chained transforms

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #6941: URL: https://github.com/apache/incubator-pinot/pull/6941#issuecomment-843763050 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated: Update Quickstart to take tmp dir as a parameter (#5445)

2021-05-19 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 1b0bb72 Update Quickstart to take tmp

[GitHub] [incubator-pinot] xiangfu0 merged pull request #5445: Update Quickstart to take tmp dir as a parameter

2021-05-19 Thread GitBox
xiangfu0 merged pull request #5445: URL: https://github.com/apache/incubator-pinot/pull/5445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5445: Update Quickstart to take tmp dir as a parameter

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #5445: URL: https://github.com/apache/incubator-pinot/pull/5445#issuecomment-843788031 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5445?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5445: Update Quickstart to take tmp dir as a parameter

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #5445: URL: https://github.com/apache/incubator-pinot/pull/5445#issuecomment-843788031 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5445?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr