siddharthteotia commented on a change in pull request #6945:
URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635687192



##########
File path: 
pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json
##########
@@ -26,23 +26,13 @@
       ]
     },
     "transformConfigs": [
-      {
-        "columnName": "group_json",
-        "transformFunction": "jsonFormat(\"group\")"
-      }
     ],
     "complexTypeConfig": {
       "unnestFields": ["group.group_topics"]
     }

Review comment:
       Right. So group_topics is the collection we are unnesting and inside 
this collection I don't think there is another collection. So if we put some 
dummy data to create another array inside group_topics, then we can add the 
following unnest config to the test 
   
   ```
   "complexTypeConfig": {      
      "unnestFields": [
          "group.group_topics",
          "group.group_topics.inner_array"
       ]   
    }
   ```
   
   I don't think unnesting collection inside another collection is covered in 
other tests. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to