mcvsubbu commented on a change in pull request #6936:
URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635484008
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
##########
@@ -102,8 +103,17 @@ protected BrokerResponseNative processBrokerRequest(long
requestId, BrokerReques
dataTableMap.put(entry.getKey(), dataTable);
totalResponseSize += serverResponse.getResponseSize();
}
+ long serverProcessingTimeMs = serverResponse.getServerProcessingTimeMs();
+ if (serverProcessingTimeMs > -1) {
Review comment:
Do we need this check?
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java
##########
@@ -30,6 +30,8 @@
QUERY_EXECUTION,
QUERY_ROUTING,
SCATTER_GATHER,
+ SERVER_PROCESSING,
Review comment:
We have often seen the case when either server or broker goes through a
gc just as the response is being sent by server or received by broker. In this
case, gc time will show up as the "network time" you are measuring? On the
server side, it will be the gc time included as "server time", but on the
broker, if it receives the bytes from server and then slips into gc (presumably
to copy the bytes in, so it is likely to happen), then we will see the gc time
as netty time, right?
What exactly is the problem faced that we could not get an answer for using
the current set of metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
