xiangfu0 commented on a change in pull request #5446:
URL: https://github.com/apache/incubator-pinot/pull/5446#discussion_r635735037
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -102,25 +101,43 @@
// Participant Helix manager handles Helix functionality such as state
transitions and messages
private HelixManager _participantHelixManager;
+ @Deprecated
public HelixBrokerStarter(PinotConfiguration brokerConf, String clusterName,
String zkServer)
throws Exception {
this(brokerConf, clusterName, zkServer, null);
}
+ @Deprecated
public HelixBrokerStarter(PinotConfiguration brokerConf, String clusterName,
String zkServer,
@Nullable String brokerHost)
throws Exception {
+ this(applyBrokerConfigs(brokerConf, clusterName, zkServer, brokerHost));
+ }
+
+ @Deprecated
Review comment:
This is the only way to use the new constructor :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
