This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 4c2b36e upgrade jdk to 11
add eafbe81 upgrade jdk to 11
This update added new revisions aft
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 1e36641 upgrade jdk to 11
add 4c2b36e upgrade jdk to 11
This update added new revisions aft
siddharthteotia commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596567877
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/combine/CombineSlowOperatorsTest.java
##
@@ -65,7 +65,8 @@ public v
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 35ec287 make resizeTimeMs metric a
siddharthteotia merged pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard edfeaf1 upgrade jdk to 11
add 1e36641 upgrade jdk to 11
This update added new revisions aft
codecov-io edited a comment on pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#issuecomment-801521348
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6693?src=pr&el=h1)
Report
> Merging
[#6693](https://codecov.io/gh/apache/incubator-pinot/pull
mqliang commented on pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#issuecomment-801577577
conflict with master since
https://github.com/apache/incubator-pinot/pull/6690 get merged. Rebased and
updated.
---
codecov-io edited a comment on pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-776350585
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6567?src=pr&el=h1)
Report
> Merging
[#6567](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-788191238
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6613?src=pr&el=h1)
Report
> Merging
[#6613](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new acc24a1 Combine operators: remove redu
Jackie-Jiang merged pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596482320
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596482255
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/combine/CombineSlowOperatorsTest.java
##
@@ -65,7 +65,8 @@ public void setU
yupeng9 commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596473726
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcherFactory.java
##
@@ -118,6 +125,47 @@ public static v
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596478073
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##
@@ -41,7 +41,7 @@
REALTIME_OFFHEAP_MEMORY_USED("b
chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596478568
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -1649,63 +1651,100 @@ p
mqliang commented on a change in pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690#discussion_r596476301
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/MinMaxValueBasedSelectionOrderByCombineOperator.java
##
@@ -54,18 +
chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596474328
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -1649,63 +1651,100 @@ p
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 502d846 support blanket protection of controller endpoints
discard 816e172 re-use auth to
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard caa12bf upgrade jdk to 11
add edfeaf1 upgrade jdk to 11
This update added new revisions aft
chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596470495
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/RealtimeSegmentAssignment.java
##
@@ -85,
chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596469843
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -528,4 +542,41 @@ private
chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r596468455
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java
##
@@ -285,7 +285,7 @@ p
codecov-io commented on pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#issuecomment-801521348
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6693?src=pr&el=h1)
Report
> Merging
[#6693](https://codecov.io/gh/apache/incubator-pinot/pull/6693?s
siddharthteotia commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596451009
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##
@@ -41,7 +41,7 @@
REALTIME_OFFHEAP_MEMORY
siddharthteotia commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596447139
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/combine/CombineSlowOperatorsTest.java
##
@@ -65,7 +65,8 @@ public v
codecov-io commented on pull request #6691:
URL: https://github.com/apache/incubator-pinot/pull/6691#issuecomment-801499091
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6691?src=pr&el=h1)
Report
> Merging
[#6691](https://codecov.io/gh/apache/incubator-pinot/pull/6691?s
siddharthteotia commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596435883
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerGauge.java
##
@@ -30,7 +30,8 @@
MAX_BURST_QPS("tables",
siddharthteotia commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596435541
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##
@@ -41,6 +41,7 @@
REALTIME_OFFHEAP_MEMORY
siddharthteotia commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596435541
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##
@@ -41,6 +41,7 @@
REALTIME_OFFHEAP_MEMORY
siddharthteotia commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596433057
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##
@@ -41,6 +41,7 @@
REALTIME_OFFHEAP_MEMORY
mqliang commented on pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#issuecomment-801488551
unit test failed due to flaky networking:
```
Error: Failed to execute goal on project pinot-kafka-0.9: Could not resolve
dependencies for project org.apache.pinot
mqliang closed pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mqliang closed pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 4780db4 upgrade jdk to 11
add caa12bf upgrade jdk to 11
This update added new revisions aft
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard ebc49b4 upgrade jdk to 11
add 4780db4 upgrade jdk to 11
This update added new revisions aft
Jackie-Jiang commented on a change in pull request #6691:
URL: https://github.com/apache/incubator-pinot/pull/6691#discussion_r596378985
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/metadata/ColumnMetadata.java
##
@@ -24,6 +24,7 @@
import java.ut
codecov-io edited a comment on pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#issuecomment-797826488
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6680?src=pr&el=h1)
Report
> Merging
[#6680](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 1522297 upgrade jdk to 11
add ebc49b4 upgrade jdk to 11
This update added new revisions aft
fx19880617 commented on issue #6692:
URL:
https://github.com/apache/incubator-pinot/issues/6692#issuecomment-801328858
This seems to be an issue of license check.
Can you try to add `-Drat.skip=true` into your maven command to bypass this
error ?
Or you can add the exclude for `apach
mqliang commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596297302
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
##
@@ -64,8 +64,7 @@
ENTRIES_SCANNED_IN_FILTER("docu
mqliang opened a new pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693
## Description
NOTE: I also change the unit of BrokerMeter from "resizes" to "numResizes"
to keep consistence with ServerMeter. Let me know if I need change back.
## Upgrade Notes
mcvsubbu commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596289528
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
##
@@ -65,6 +65,7 @@
SEGMENT_DOWNLOAD_FAILURES("seg
xulinjintu commented on issue #6688:
URL:
https://github.com/apache/incubator-pinot/issues/6688#issuecomment-801320325
PS: I chose the cloud neutral term "Failure Domain" by referencing
[wikipedia](https://en.wikipedia.org/wiki/Failure_domain).
--
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596287394
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
##
@@ -65,6 +65,7 @@
SEGMENT_DOWNLOAD_FAILURES("segm
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 407fb74 upgrade jdk to 11
add 1522297 upgrade jdk to 11
This update added new revisions aft
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 4456bd3 support blanket protection of controller endpoints
add 502d846 support blanke
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 816e172 re-use auth token constant
add 4456bd3 support blanket protection of controll
Jackie-Jiang commented on a change in pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690#discussion_r596257840
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/MinMaxValueBasedSelectionOrderByCombineOperator.java
##
@@ -54
mcvsubbu commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r596245224
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -448,14 +
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from c52c9db review fixes
add 816e172 re-use auth token constant
No new revisions were ad
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 606c9fa realtime to offline segment integration test with auth
add c52c9db review fix
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596221839
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthPrincipal.java
##
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Sof
apucher commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-801255621
> I think it should be "AccessType" because AccessControl.hasAccess() takes
an AccessType object as its argument. Implementations of AccessControl can't
change AccessTyp
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596217291
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java
##
@@ -64,4 +67,36 @@ default boolean hasA
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596214769
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java
##
@@ -26,6 +26,9 @@
@InterfaceAudience.P
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596213201
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java
##
@@ -0,0 +1,90 @@
+/**
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596212308
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BasicAuthBatchIntegrationTest.java
##
@@ -0,0 +1,177 @@
+/
mcvsubbu commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596203539
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 621ceb0 Fix log message for SegmentB
mcvsubbu merged pull request #6684:
URL: https://github.com/apache/incubator-pinot/pull/6684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pabrahamusa commented on issue #6532:
URL:
https://github.com/apache/incubator-pinot/issues/6532#issuecomment-801201275
@mcvsubbu I am using AWS so the terms could be more AWS specific. However
anything like 'island' will cover my requirement and should work for all
cloud providers as
LutzWeischerFujitsu opened a new issue #6692:
URL: https://github.com/apache/incubator-pinot/issues/6692
[jw@cn05 pinot]$ mvn install -DskipTests -Pbin-dist
...
[INFO] Installing artifact
/home/jw/.m2/repository/org/apache/logging/log4j/log4j-core/2.11.2/log4j-core-2.11.2.jar
to
/ho
codecov-io commented on pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690#issuecomment-800922616
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6690?src=pr&el=h1)
Report
> Merging
[#6690](https://codecov.io/gh/apache/incubator-pinot/pull/6690?s
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 520364a upgrade jdk to 11
add 407fb74 upgrade jdk to 11
This update added new revisions aft
codecov-io edited a comment on pull request #6684:
URL: https://github.com/apache/incubator-pinot/pull/6684#issuecomment-800757757
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6684?src=pr&el=h1)
Report
> Merging
[#6684](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_jdk_11
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 42907fd upgrade jdk to 11
add 520364a upgrade jdk to 11
This update added new revisions aft
68 matches
Mail list logo