[incubator-pinot] branch master updated: Fix log message for SegmentBuildTimeLeaseExtender (#6684)

[mcvsubbu]

This is an automated email from the ASF dual-hosted git repository.

mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 621ceb0  Fix log message for SegmentBuildTimeLeaseExtender (#6684)
621ceb0 is described below

commit 621ceb021cefa1640708f3bb4d576270717f70d6
Author: Jiapeng Tao <jia...@linkedin.com>
AuthorDate: Wed Mar 17 09:42:15 2021 -0700

    Fix log message for SegmentBuildTimeLeaseExtender (#6684)
---
 .../core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java | 8 ++++++--
 .../pinot/server/starter/helix/HelixInstanceDataManager.java      | 2 --
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
index 725dc95..6dc2008 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
@@ -56,6 +56,7 @@ public class SegmentBuildTimeLeaseExtender {
 
   public static void initExecutor() {
     _executor = new ScheduledThreadPoolExecutor(1);
+    LOGGER.info("Initialized segment build time lease extender executor");
   }
 
   public static void shutdownExecutor() {
@@ -63,6 +64,7 @@ public class SegmentBuildTimeLeaseExtender {
       _executor.shutdownNow();
       _executor = null;
     }
+    LOGGER.info("Shut down segment build time lease extender executor");
   }
 
   @VisibleForTesting
@@ -78,9 +80,11 @@ public class SegmentBuildTimeLeaseExtender {
       ServerMetrics serverMetrics, String tableNameWithType) {
     return TABLE_TO_LEASE_EXTENDER.compute(tableNameWithType, (k, v) -> {
       if (v == null) {
-        return new SegmentBuildTimeLeaseExtender(instanceId, serverMetrics, 
tableNameWithType);
+        SegmentBuildTimeLeaseExtender leaseExtender = new 
SegmentBuildTimeLeaseExtender(instanceId, serverMetrics, tableNameWithType);
+        LOGGER.info("Created lease extender for table: {}", tableNameWithType);
+        return leaseExtender;
       } else {
-        LOGGER.warn("Lease extender for Table: {} already exists", 
tableNameWithType);
+        LOGGER.warn("Lease extender for table: {} already exists", 
tableNameWithType);
         return v;
       }
     });
diff --git 
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
 
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
index 30ba125..c0dc9df 100644
--- 
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
+++ 
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
@@ -94,7 +94,6 @@ public class HelixInstanceDataManager implements 
InstanceDataManager {
 
     // Initialize segment build time lease extender executor
     SegmentBuildTimeLeaseExtender.initExecutor();
-    LOGGER.info("Initialized segment build time lease extender executor");
 
     // Initialize the table data manager provider
     TableDataManagerProvider.init(_instanceDataManagerConfig);
@@ -113,7 +112,6 @@ public class HelixInstanceDataManager implements 
InstanceDataManager {
       tableDataManager.shutDown();
     }
     SegmentBuildTimeLeaseExtender.shutdownExecutor();
-    LOGGER.info("Segment build time lease extender executor shut down");
     LOGGER.info("Helix instance data manager shut down");
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org