mcvsubbu commented on a change in pull request #6680: URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r596203539
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java ########## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.lang.management.ManagementFactory; +import java.lang.management.ThreadMXBean; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * The {@code ThreadTimer} class providing the functionality of measuring the CPU time for the current thread. + */ +public class ThreadTimer { + private static final ThreadMXBean MX_BEAN = ManagementFactory.getThreadMXBean(); + private static final boolean IS_CURRENT_THREAD_CPU_TIME_SUPPORTED = MX_BEAN.isCurrentThreadCpuTimeSupported(); + private static final Logger LOGGER = LoggerFactory.getLogger(ThreadTimer.class); + private static boolean IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED; + private long _startTimeNs = -1; + private long _endTimeNs = -1; + + public ThreadTimer() { + } + + public static boolean isCurrentThreadCpuTimeSupported() { Review comment: remove this method, we should not need it. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java ########## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.lang.management.ManagementFactory; +import java.lang.management.ThreadMXBean; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * The {@code ThreadTimer} class providing the functionality of measuring the CPU time for the current thread. + */ +public class ThreadTimer { + private static final ThreadMXBean MX_BEAN = ManagementFactory.getThreadMXBean(); + private static final boolean IS_CURRENT_THREAD_CPU_TIME_SUPPORTED = MX_BEAN.isCurrentThreadCpuTimeSupported(); + private static final Logger LOGGER = LoggerFactory.getLogger(ThreadTimer.class); + private static boolean IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED; + private long _startTimeNs = -1; + private long _endTimeNs = -1; + + public ThreadTimer() { + } + + public static boolean isCurrentThreadCpuTimeSupported() { + return IS_CURRENT_THREAD_CPU_TIME_SUPPORTED; + } + + public void start() { + if (IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED && IS_CURRENT_THREAD_CPU_TIME_SUPPORTED) { + _startTimeNs = MX_BEAN.getCurrentThreadCpuTime(); + } + } + + public void stop() { + if (IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED && IS_CURRENT_THREAD_CPU_TIME_SUPPORTED) { + _endTimeNs = MX_BEAN.getCurrentThreadCpuTime(); + } + } + + public long getThreadTimeNs() { + if (_startTimeNs == -1 || _endTimeNs == -1) { + return 0; + } + return _endTimeNs - _startTimeNs; + } + + public long stopAndGetThreadTimeNs() { + stop(); + return getThreadTimeNs(); + } + + static { + LOGGER.info("Current thread cpu time measurement supported: {}", IS_CURRENT_THREAD_CPU_TIME_SUPPORTED); + } + + public static void setThreadCpuTimeMeasurementEnabled(boolean enable) { + IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED = enable; Review comment: In this method, call ManagementFactory.getMxBean, and then decide once and for all whether we are going to measure thread cpu time or not, and store it in a single boolean variable, to be checked every time start/stop is invoked. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
