apucher commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-801255621


   > I think it should be "AccessType" because AccessControl.hasAccess() takes 
an AccessType object as its argument. Implementations of AccessControl can't 
change AccessType.
   
   I agree with this from the controller side, however, `AccessType` is a 
controller concept only - broker implementations may specify other types of 
access in an extensible way. One could imagine limiting access to PII data and 
similar


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to