This is an automated email from the ASF dual-hosted git repository.
yupeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5d07ea4 Update links for 0.7.0 release
yupeng9 merged pull request #6683:
URL: https://github.com/apache/incubator-pinot/pull/6683
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Jackie-Jiang commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594871052
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,39 +46,58 @@
yupeng9 opened a new pull request #6683:
URL: https://github.com/apache/incubator-pinot/pull/6683
Update links for 0.7.0 release in the website
This is an automated message from the Apache Git Service.
To respond to the m
codecov-io edited a comment on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-788191238
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6613?src=pr&el=h1)
Report
> Merging
[#6613](https://codecov.io/gh/apache/incubator-pinot/pull
Jackie-Jiang commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594840078
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,39 +46,58 @@
codecov-io commented on pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#issuecomment-799909360
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6682?src=pr&el=h1)
Report
> Merging
[#6682](https://codecov.io/gh/apache/incubator-pinot/pull/6682?s
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 59cdaee review fixes
add 351a0f9 added header support to connection factory
add
codecov-io edited a comment on pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#issuecomment-797826488
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6680?src=pr&el=h1)
Report
> Merging
[#6680](https://codecov.io/gh/apache/incubator-pinot/pull
jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594810131
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,25 +46,25 @@
//
apucher commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-799883906
> > > Do you need to change LLCSegmentCompletionHandlers to pay attention to
the auth token?
> >
> >
> > Probably. I'd appreciate your input on where this actu
jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594794912
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,25 +46,25 @@
//
jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594794451
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##
@@ -765,6 +768,20 @@ p
jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594793769
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##
@@ -128,9 +131,9 @@ pr
jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594793769
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##
@@ -128,9 +131,9 @@ pr
mcvsubbu commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-799867494
> > Do you need to change LLCSegmentCompletionHandlers to pay attention to
the auth token?
>
> Probably. I'd appreciate your input on where this actually talks to
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594783750
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##
@@ -89,12 +92,28 @@ protected Intermedi
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594783534
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##
@@ -53,15 +55,16 @@
protected final
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594783507
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##
@@ -44,6 +44,7 @@
String REQUEST_ID_METADATA_KEY = "r
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594783420
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594783322
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the
mqliang closed pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
yupeng pushed a change to annotated tag release-0.7.0
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
*** WARNING: tag release-0.7.0 was modified! ***
from de0236c (commit)
to a49a85b (tag)
t
mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r594777195
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##
@@ -89,12 +92,28 @@ protected Intermedi
apucher commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-799842929
> Do you need to change LLCSegmentCompletionHandlers to pay attention to the
auth token?
Probably. I'd appreciate your input on where this actually talks to
contr
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594771418
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -180,6 +180,16 @@ public Brok
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594764360
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##
@@ -168,11 +185,19 @@ public static URI g
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from eb4f5ac add batch ingestion test
add 59cdaee review fixes
No new revisions were adde
Author: yupeng
Date: Mon Mar 15 23:38:31 2021
New Revision: 46637
Log:
Move staging of 0.7.0 to official release
Added:
release/incubator/pinot/apache-pinot-incubating-0.7.0/
- copied from r46636,
dev/incubator/pinot/apache-pinot-incubating-0.7.0-rc1/
Removed:
dev/incubator/pinot/
mcvsubbu commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594761496
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -180,6 +180,16 @@ public Bro
mcvsubbu commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r594750850
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupInfo.java
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache So
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594752354
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##
@@ -305,6 +312,12 @@
public static final St
apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594751564
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -180,6 +180,16 @@ public Brok
mcvsubbu commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594721563
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -180,6 +180,16 @@ public Bro
snleee commented on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799799483
@mcvsubbu You're right. I got confused. It keeps using the same lease
extender since it looks up based on the instanceId
mcvsubbu commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594708671
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,25 +46,25 @@
mcvsubbu commented on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799773072
@snleee The existing implementation may not route to the correct controller
in multi-tenant use cases. If you notice, the constructor of lease extender
takes a table name,
jackjlli commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594688627
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##
@@ -765,6 +768,20 @@
codecov-io edited a comment on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-788191238
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6613?src=pr&el=h1)
Report
> Merging
[#6613](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-controller
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from ff04de3 review fixes
add eb4f5ac add batch ingestion test
No new revisions were adde
Jackie-Jiang commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594577905
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,25 +46,25 @@
Jackie-Jiang commented on issue #6532:
URL:
https://github.com/apache/incubator-pinot/issues/6532#issuecomment-799636614
Instance pool concept can be used as the availability set. Please read:
https://docs.pinot.apache.org/operators/operating-pinot/instance-assignment#pool-based-instance-a
Jackie-Jiang commented on a change in pull request #6653:
URL: https://github.com/apache/incubator-pinot/pull/6653#discussion_r594564224
##
File path:
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
##
@@ -244,6 +243,62 @@ public Response d
snleee edited a comment on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening.
`ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`.
2. The main issue was
snleee edited a comment on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening.
`ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`.
2. The main issue was
snleee edited a comment on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening.
`ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`.
2. The main issue was
snleee edited a comment on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening.
`ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`.
2. The main issue was
snleee commented on issue #6671:
URL:
https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening.
`ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`.
2. The main issue was that th
snleee commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594550502
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##
@@ -46,25 +46,25 @@
//
snleee commented on pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#issuecomment-799620806
#6671
This is an automated message from the Apache Git Service.
To respond to the message, please log on
50 matches
Mail list logo
