snleee edited a comment on issue #6671: URL: https://github.com/apache/incubator-pinot/issues/6671#issuecomment-799623646
1. The routing back to the proper leader controller has been happening. `ServerSegmentCompletionProtocolHandler:createSegmentCompletionUrl()`. 2. The main issue was that the server-side only had the lease extender per instance id, so each server has had 1 single global lease extender. `shutdown()` call from a single data manager affected the lease extender for other data managers. 3. @jtao15's fix changes servers to have lease extender per table. I think that this is cleaner and even simpler than having one global lease extender (1-1 mapping for lease extender - data manager for a table). `ServerSegmentCompletionProtocolHandler` needs the table name so we actually need to instantiate the lease extender with the table name. @mcvsubbu How do you think? Can you also review the above PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
